Widen type from array to mixed so that invalid values can be handled in the right place

Author: sebastianbergmann

src/Metadata/Metadata.php

@@ -413,7 +413,7 @@ public static function testDoxOnMethod(string $text): TestDox
         return new TestDox(self::METHOD_LEVEL, $text);
     }
 
-    public static function testWith(array $data): TestWith
+    public static function testWith(mixed $data): TestWith
     {
         return new TestWith(self::METHOD_LEVEL, $data);
     }

src/Metadata/TestWith.php

@@ -16,12 +16,12 @@
  */
 final class TestWith extends Metadata
 {
-    private readonly array $data;
+    private readonly mixed $data;
 
     /**
      * @psalm-param 0|1 $level
      */
-    protected function __construct(int $level, array $data)
+    protected function __construct(int $level, mixed $data)
     {
         parent::__construct($level);
 
@@ -36,7 +36,7 @@ public function isTestWith(): bool
         return true;
     }
 
-    public function data(): array
+    public function data(): mixed
     {
         return $this->data;
     }

tests/_files/Metadata/Attribute/tests/TestWithInvalidValueTest.php

@@ -0,0 +1,22 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of PHPUnit.
+ *
+ * (c) Sebastian Bergmann <sebastian@phpunit.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace PHPUnit\TestFixture\Metadata\Attribute;
+
+use PHPUnit\Framework\Attributes\TestWithJson;
+use PHPUnit\Framework\TestCase;
+
+final class TestWithInvalidValueTest extends TestCase
+{
+    #[TestWithJson('false')]
+    public function testOne($one, $two): void
+    {
+        $this->assertTrue(true);
+    }
+}

tests/end-to-end/event/testwithjson-attribute-invalid-value.phpt

@@ -0,0 +1,27 @@
+--TEST--
+The right events are emitted in the right order for a test that uses a TestWithJson attribute which provides an invalid value
+--FILE--
+<?php declare(strict_types=1);
+$_SERVER['argv'][] = '--do-not-cache-result';
+$_SERVER['argv'][] = '--no-configuration';
+$_SERVER['argv'][] = '--debug';
+$_SERVER['argv'][] = __DIR__ . '/../../_files/Metadata/Attribute/tests/TestWithInvalidValueTest.php';
+
+require __DIR__ . '/../../bootstrap.php';
+
+(new PHPUnit\TextUI\Application)->run($_SERVER['argv']);
+--EXPECTF--
+PHPUnit Started (PHPUnit %s using %s)
+Test Runner Configured
+Test Triggered PHPUnit Error (PHPUnit\TestFixture\Metadata\Attribute\TestWithInvalidValueTest::testOne)
+The data provider specified for PHPUnit\TestFixture\Metadata\Attribute\TestWithInvalidValueTest::testOne is invalid
+Data set #0 is invalid
+Test Runner Triggered Warning (No tests found in class "PHPUnit\TestFixture\Metadata\Attribute\TestWithInvalidValueTest".)
+Test Suite Loaded (0 tests)
+Event Facade Sealed
+Test Runner Started
+Test Suite Sorted
+Test Runner Execution Started (0 tests)
+Test Runner Execution Finished
+Test Runner Finished
+PHPUnit Finished (Shell Exit Code: 2)