Define WhereClause#collection

Follow-up to rails#460

Expose the underlying `ActiveResource::Collection` instance for the
`WhereClause` class returned from `Base.all` and `Base.where`. To do so,
rename the previously private `resources` method to `collection`, and
move it to a public declaration.

Author: seanpdoyle

lib/active_resource/where_clause.rb

@@ -2,13 +2,13 @@
 
 module ActiveResource
   class WhereClause < BasicObject # :nodoc:
-    delegate :==, to: :resources
-    delegate_missing_to :resources
+    delegate :==, to: :collection
+    delegate_missing_to :collection
 
     def initialize(resource_class, options = {})
       @resource_class = resource_class
       @options = options
-      @resources = nil
+      @collection = nil
       @loaded = false
     end
 
@@ -22,7 +22,7 @@ def all(options = {})
 
     def load
       unless @loaded
-        @resources = @resource_class.find(:all, @options)
+        @collection = @resource_class.find(:all, @options)
         @loaded = true
       end
 
@@ -34,14 +34,15 @@ def reload
       load
     end
 
+    def collection
+      load
+      @collection
+    end
+
     private
-      def resources
-        load
-        @resources
-      end
 
       def reset
-        @resources = nil
+        @collection = nil
         @loaded = false
       end
   end

test/cases/finder_test.rb

@@ -85,6 +85,7 @@ def test_where_with_multiple_where_clauses
     ActiveResource::HttpMock.respond_to.get "/people.json?id=2&name=david", {}, @people_david
 
     people = Person.where(id: 2).where(name: "david")
+    assert_kind_of Person.collection_parser, people.collection
     assert_equal 1, people.size
     assert_kind_of Person, people.first
     assert_equal 2, people.first.id