Add tests for endpoints with and without origins

Author: razor-x

src/lib/seam/connect/seam-http-request.ts

@@ -46,22 +46,23 @@ export class SeamHttpRequest<
 
   public get url(): URL {
     const { client } = this.#parent
-    const baseUrl = client.defaults.baseURL
-    if (baseUrl === undefined) {
-      throw new Error('baseUrl is required')
-    }
-
-    const params = this.#config.params
-    if (params === undefined) {
-      return new URL(this.#config.path, baseUrl)
-    }
+    const { params } = this.#config
 
     const serializer =
       typeof client.defaults.paramsSerializer === 'function'
         ? client.defaults.paramsSerializer
         : serializeUrlSearchParams
 
-    return new URL(`${this.#config.path}?${serializer(params)}`, baseUrl)
+    const origin = getUrlPrefix(client.defaults.baseURL ?? '')
+
+    const pathname = this.#config.path.startsWith('/')
+      ? this.#config.path
+      : `/${this.#config.path}`
+
+    const path =
+      params == null ? pathname : [pathname, serializer(params)].join('?')
+
+    return new URL([origin, path].join(''))
   }
 
   public get method(): Method {
@@ -128,3 +129,17 @@ export class SeamHttpRequest<
     return this.execute().then(onfulfilled, onrejected)
   }
 }
+
+const getUrlPrefix = (input: string): string => {
+  try {
+    const url = new URL(input).toString()
+    if (url.endsWith('/')) return url.slice(0, -1)
+    return url
+  } catch (err: unknown) {
+    if (globalThis.location != null) {
+      const pathname = input.startsWith('/') ? input : `/${input}`
+      return new URL([globalThis.location.origin, pathname].join('')).toString()
+    }
+    throw err
+  }
+}

test/seam/connect/seam-http-request.test.ts

@@ -65,6 +65,87 @@ test('SeamHttpRequest: url is a URL for get requests', async (t) => {
   )
 })
 
+test('SeamHttpRequest: url is a URL when endpoint is a url without a path', async (t) => {
+  const { seed } = await getTestServer(t)
+  const seam = SeamHttp.fromApiKey(seed.seam_apikey1_token, {
+    endpoint: 'https://example.com',
+  })
+
+  const { url } = seam.devices.get({ device_id: 'abc123' })
+
+  t.true(url instanceof URL)
+  t.deepEqual(
+    toPlainUrlObject(url),
+    toPlainUrlObject(new URL('https://example.com/devices/get')),
+  )
+})
+
+test('SeamHttpRequest: url is a URL when endpoint is a url with a path', async (t) => {
+  const { seed } = await getTestServer(t)
+  const seam = SeamHttp.fromApiKey(seed.seam_apikey1_token, {
+    endpoint: 'https://example.com/some/sub/path',
+  })
+
+  const { url } = seam.devices.get({ device_id: 'abc123' })
+
+  t.true(url instanceof URL)
+  t.deepEqual(
+    toPlainUrlObject(url),
+    toPlainUrlObject(new URL('https://example.com/some/sub/path/devices/get')),
+  )
+})
+
+test.failing(
+  'SeamHttpRequest: url is a URL when endpoint is path',
+  async (t) => {
+    const { seed } = await getTestServer(t)
+    const seam = SeamHttp.fromApiKey(seed.seam_apikey1_token, {
+      endpoint: '/some/sub/path',
+    })
+
+    const { url } = seam.devices.get({ device_id: 'abc123' })
+
+    t.true(url instanceof URL)
+    t.deepEqual(
+      toPlainUrlObject(url),
+      toPlainUrlObject(
+        new URL('https://example.com/some/sub/path/devices/get'),
+      ),
+    )
+  },
+)
+
+test.failing(
+  'SeamHttpRequest: url is a URL when endpoint is empty',
+  async (t) => {
+    const { seed } = await getTestServer(t)
+    const seam = SeamHttp.fromApiKey(seed.seam_apikey1_token, {
+      endpoint: '',
+    })
+
+    // TODO: Set globalThis.location.origin = 'https://example.com'
+
+    const { url } = seam.devices.get({ device_id: 'abc123' })
+
+    t.true(url instanceof URL)
+    t.deepEqual(
+      toPlainUrlObject(url),
+      toPlainUrlObject(new URL('https://example.com/devices/get')),
+    )
+  },
+)
+
+test('SeamHttpRequest: url throws if unable to resolve origin', async (t) => {
+  const { seed } = await getTestServer(t)
+  const seam = SeamHttp.fromApiKey(seed.seam_apikey1_token, {
+    endpoint: '',
+  })
+
+  const request = seam.devices.get({ device_id: 'abc123' })
+
+  t.throws(() => request.url, { code: 'ERR_INVALID_URL' })
+})
+
 const toPlainUrlObject = (url: URL): Omit<URL, 'searchParams' | 'toJSON'> => {
   return {
     pathname: url.pathname,