Skip to content

refactor: use t.TempDir() instead of os.MkdirTemp #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: use t.TempDir() instead of os.MkdirTemp #1703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions x/registration/internal/keeper/genesis_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ import (
)

func TestInitGenesisNoMaster(t *testing.T) {
tempDir, err := os.MkdirTemp("", "wasm")
require.NoError(t, err)
defer os.RemoveAll(tempDir)
tempDir := t.TempDir()
ctx, keeper := CreateTestInput(t, false, tempDir, true)

data := types.GenesisState{
Expand All @@ -25,9 +23,7 @@ func TestInitGenesisNoMaster(t *testing.T) {
}

func TestInitGenesis(t *testing.T) {
tempDir, err := os.MkdirTemp("", "wasm")
require.NoError(t, err)
defer os.RemoveAll(tempDir)
tempDir := t.TempDir()
ctx, keeper := CreateTestInput(t, false, tempDir, true)

cert, err := os.ReadFile("../../testdata/attestation_cert_sw")
Expand All @@ -46,9 +42,7 @@ func TestInitGenesis(t *testing.T) {
}

func TestExportGenesis(t *testing.T) {
tempDir, err := os.MkdirTemp("", "wasm")
require.NoError(t, err)
defer os.RemoveAll(tempDir)
tempDir := t.TempDir()
ctx, keeper := CreateTestInput(t, false, tempDir, true)

cert, err := os.ReadFile("../../testdata/attestation_cert_sw")
Expand Down
16 changes: 4 additions & 12 deletions x/registration/internal/keeper/keeper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,13 @@ func init() {
}

func TestNewKeeper(t *testing.T) {
tempDir, err := os.MkdirTemp("", "reg")
require.NoError(t, err)
defer os.RemoveAll(tempDir)
tempDir := t.TempDir()
_, regKeeper := CreateTestInput(t, false, tempDir, true)
require.NotNil(t, regKeeper)
}

func TestNewKeeper_Node(t *testing.T) {
tempDir, err := os.MkdirTemp("", "reg")
require.NoError(t, err)
defer os.RemoveAll(tempDir)
tempDir := t.TempDir()

seedPath := filepath.Join(tempDir, types.SecretNodeCfgFolder, types.SecretNodeSeedNewConfig)

Expand All @@ -46,9 +42,7 @@ func TestNewKeeper_Node(t *testing.T) {
}

func TestKeeper_RegisterationStore(t *testing.T) {
tempDir, err := os.MkdirTemp("", "wasm")
require.NoError(t, err)
defer os.RemoveAll(tempDir)
tempDir := t.TempDir()
ctx, regKeeper := CreateTestInput(t, false, tempDir, true)

cert, err := os.ReadFile("../../testdata/attestation_cert_sw")
Expand All @@ -72,9 +66,7 @@ func TestKeeper_RegisterationStore(t *testing.T) {
}

func TestKeeper_RegisterNode(t *testing.T) {
tempDir, err := os.MkdirTemp("", "wasm")
require.NoError(t, err)
defer os.RemoveAll(tempDir)
tempDir := t.TempDir()
ctx, regKeeper := CreateTestInput(t, false, tempDir, true)

cert, err := os.ReadFile("../../testdata/attestation_cert_sw.combined")
Expand Down
12 changes: 3 additions & 9 deletions x/registration/internal/keeper/querier_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ import (
// ////

func TestNewQuerier_MasterKey(t *testing.T) {
tempDir, err := os.MkdirTemp("", "wasm")
require.NoError(t, err)
defer os.RemoveAll(tempDir)
tempDir := t.TempDir()
ctx, keeper := CreateTestInput(t, false, tempDir, true)

querier := NewQuerier(keeper)
Expand All @@ -45,9 +43,7 @@ func TestNewQuerier_MasterKey(t *testing.T) {
}

func TestNewQuerier_MalformedNodeID(t *testing.T) {
tempDir, err := os.MkdirTemp("", "wasm")
require.NoError(t, err)
defer os.RemoveAll(tempDir)
tempDir := t.TempDir()
ctx, keeper := CreateTestInput(t, false, tempDir, true)

nodeIdInvalid := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
Expand Down Expand Up @@ -75,9 +71,7 @@ func TestNewQuerier_MalformedNodeID(t *testing.T) {
}

func TestNewQuerier_ValidNodeID(t *testing.T) {
tempDir, err := os.MkdirTemp("", "wasm")
require.NoError(t, err)
defer os.RemoveAll(tempDir)
tempDir := t.TempDir()
ctx, keeper := CreateTestInput(t, false, tempDir, true)

querier := NewQuerier(keeper) // TODO: Should test NewQuerier() as well
Expand Down
Loading