Fix dropdown menus in pen blocks

scratchcpp/libscratchcpp#558

Author: adazem009

src/blocks/penblocks.cpp

@@ -85,8 +85,7 @@ void PenBlocks::compileChangePenColorParamBy(libscratchcpp::Compiler *compiler)
 {
     Input *input = compiler->input(COLOR_PARAM);
 
-    if (input->type() != Input::Type::ObscuredShadow) {
-        assert(input->pointsToDropdownMenu());
+    if (input->pointsToDropdownMenu()) {
         std::string value = input->selectedMenuItem();
         BlockFunc f = nullptr;
 
@@ -114,8 +113,7 @@ void PenBlocks::compileSetPenColorParamTo(Compiler *compiler)
 {
     Input *input = compiler->input(COLOR_PARAM);
 
-    if (input->type() != Input::Type::ObscuredShadow) {
-        assert(input->pointsToDropdownMenu());
+    if (input->pointsToDropdownMenu()) {
         std::string value = input->selectedMenuItem();
         BlockFunc f = nullptr;
 

test/blocks/pen_blocks_test.cpp

@@ -54,6 +54,7 @@ class PenBlocksTest : public testing::Test
             else {
                 auto input = addNullInput(block, name, id);
                 auto menu = std::make_shared<Block>(block->id() + "_menu", block->opcode() + "_menu");
+                menu->setShadow(true);
                 input->setValueBlock(menu);
                 addDropdownField(menu, name, -1, selectedValue, -1);
             }