Enable convex hull points for stage

Author: adazem009

src/renderedtarget.cpp

@@ -463,9 +463,6 @@ void RenderedTarget::clearGraphicEffects()
 
 void RenderedTarget::updateHullPoints(QOpenGLFramebufferObject *fbo)
 {
-    if (m_stageModel)
-        return; // hull points are useless for the stage
-
     Q_ASSERT(fbo);
     int width = fbo->width();
     int height = fbo->height();

test/renderedtarget/renderedtarget_test.cpp

@@ -326,10 +326,6 @@ TEST_F(RenderedTargetTest, HullPoints)
     target.updateHullPoints(&fbo);
     ASSERT_EQ(target.hullPoints(), std::vector<QPointF>({ { 1, 1 }, { 2, 1 }, { 3, 1 }, { 1, 2 }, { 3, 2 }, { 1, 3 }, { 2, 3 }, { 3, 3 } }));
 
-    // Release
-    fbo.release();
-    context.doneCurrent();
-
     // Test contains()
     ASSERT_FALSE(target.contains({ 0, 0 }));
     ASSERT_FALSE(target.contains({ 1, 0 }));
@@ -351,6 +347,51 @@ TEST_F(RenderedTargetTest, HullPoints)
     ASSERT_TRUE(target.contains({ 2, 3 }));
     ASSERT_TRUE(target.contains({ 3, 3 }));
     ASSERT_FALSE(target.contains({ 3.3, 3.5 }));
+
+    // Stage: hull points
+    Stage stage;
+    StageModel stageModel;
+    stageModel.init(&stage);
+    target.setSpriteModel(nullptr);
+    target.setStageModel(&stageModel);
+
+    target.setWidth(3);
+    target.setHeight(3);
+    fbo.release();
+    QOpenGLFramebufferObject emptyFbo(fbo.size(), format);
+    emptyFbo.bind();
+    target.updateHullPoints(&emptyFbo); // clear the convex hull points list
+    ASSERT_TRUE(target.hullPoints().empty());
+    emptyFbo.release();
+    fbo.bind();
+    target.updateHullPoints(&fbo);
+    ASSERT_EQ(target.hullPoints(), std::vector<QPointF>({ { 1, 1 }, { 2, 1 }, { 3, 1 }, { 1, 2 }, { 3, 2 }, { 1, 3 }, { 2, 3 }, { 3, 3 } }));
+
+    // Stage: contains()
+    ASSERT_TRUE(target.contains({ 0, 0 }));
+    ASSERT_TRUE(target.contains({ 1, 0 }));
+    ASSERT_TRUE(target.contains({ 2, 0 }));
+    ASSERT_TRUE(target.contains({ 3, 0 }));
+
+    ASSERT_TRUE(target.contains({ 0, 1 }));
+    ASSERT_TRUE(target.contains({ 1, 1 }));
+    ASSERT_TRUE(target.contains({ 1.4, 1.25 }));
+    ASSERT_TRUE(target.contains({ 2, 1 }));
+    ASSERT_TRUE(target.contains({ 3, 1 }));
+
+    ASSERT_TRUE(target.contains({ 1, 2 }));
+    ASSERT_TRUE(target.contains({ 2, 2 }));
+    ASSERT_TRUE(target.contains({ 3, 2 }));
+    ASSERT_TRUE(target.contains({ 3.5, 2.1 }));
+
+    ASSERT_TRUE(target.contains({ 1, 3 }));
+    ASSERT_TRUE(target.contains({ 2, 3 }));
+    ASSERT_TRUE(target.contains({ 3, 3 }));
+    ASSERT_TRUE(target.contains({ 3.3, 3.5 }));
+
+    // Release
+    fbo.release();
+    context.doneCurrent();
 }
 
 TEST_F(RenderedTargetTest, SpriteDragging)