Merge pull request #337 from scratchcpp/string_to_double_locale

Fix #331: Fix string conversion issues caused by the locale

Author: adazem009

include/scratchcpp/value.h

@@ -799,8 +799,15 @@ class LIBSCRATCHCPP_EXPORT Value
                 if (ok)
                     *ok = true;
 
+                // Set locale to C to avoid conversion issues
+                std::string oldLocale = std::setlocale(LC_NUMERIC, nullptr);
+                std::setlocale(LC_NUMERIC, "C");
+
                 double ret = std::stod(*stringPtr);
 
+                // Restore old locale
+                std::setlocale(LC_NUMERIC, oldLocale.c_str());
+
                 if (customStr)
                     delete stringPtr;
 

test/scratch_classes/value_test.cpp

@@ -135,6 +135,24 @@ TEST(ValueTest, StdStringConstructor)
         ASSERT_FALSE(v.isString());
     }
 
+    {
+        std::string oldLocale = std::setlocale(LC_NUMERIC, nullptr);
+        std::setlocale(LC_NUMERIC, "sk_SK.UTF-8");
+
+        Value v(std::string("532.15"));
+
+        std::setlocale(LC_NUMERIC, oldLocale.c_str());
+
+        ASSERT_EQ(v.toString(), "532.15");
+        ASSERT_EQ(v.type(), Value::Type::Double);
+        ASSERT_FALSE(v.isInfinity());
+        ASSERT_FALSE(v.isNegativeInfinity());
+        ASSERT_FALSE(v.isNaN());
+        ASSERT_TRUE(v.isNumber());
+        ASSERT_FALSE(v.isBool());
+        ASSERT_FALSE(v.isString());
+    }
+
     {
         Value v(std::string("1 2 3"));
         ASSERT_EQ(v.toString(), "1 2 3");