Do not set bubble text in hidden sprites

Author: adazem009

src/scratch/sprite.cpp

@@ -441,7 +441,7 @@ void Sprite::setBubbleType(BubbleType type)
 /*! Overrides Target#setBubbleText(). */
 void Sprite::setBubbleText(const std::string &text)
 {
-    Target::setBubbleText(text);
+    Target::setBubbleText(impl->visible ? text : "");
 
     if (impl->visible && !text.empty()) {
         IEngine *eng = engine();
@@ -451,7 +451,7 @@ void Sprite::setBubbleText(const std::string &text)
     }
 
     if (impl->iface)
-        impl->iface->onBubbleTextChanged(text);
+        impl->iface->onBubbleTextChanged(impl->visible ? text : "");
 }
 
 Target *Sprite::dataSource() const

test/scratch_classes/sprite_test.cpp

@@ -636,8 +636,12 @@ TEST(SpriteTest, GraphicsEffects)
 TEST(SpriteTest, BubbleType)
 {
     Sprite sprite;
+    EngineMock engine;
+    sprite.setEngine(&engine);
     ASSERT_EQ(sprite.bubbleType(), Target::BubbleType::Say);
 
+    EXPECT_CALL(engine, requestRedraw).Times(0);
+
     sprite.setBubbleType(Target::BubbleType::Think);
     ASSERT_EQ(sprite.bubbleType(), Target::BubbleType::Think);
 
@@ -648,11 +652,22 @@ TEST(SpriteTest, BubbleType)
 TEST(SpriteTest, BubbleText)
 {
     Sprite sprite;
+    EngineMock engine;
+    sprite.setVisible(true);
+    sprite.setEngine(&engine);
     ASSERT_TRUE(sprite.bubbleText().empty());
 
+    EXPECT_CALL(engine, requestRedraw());
     sprite.setBubbleText("hello");
     ASSERT_EQ(sprite.bubbleText(), "hello");
 
+    EXPECT_CALL(engine, requestRedraw());
     sprite.setBubbleText("world");
     ASSERT_EQ(sprite.bubbleText(), "world");
+
+    sprite.setVisible(false);
+
+    EXPECT_CALL(engine, requestRedraw).Times(0);
+    sprite.setBubbleText("test");
+    ASSERT_TRUE(sprite.bubbleText().empty());
 }