Skip to content

Commit aaa64f5

Browse files
committed
fix #352: Read vectors by reference in resolveIds() and compile()
1 parent 6c8f384 commit aaa64f5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/engine/internal/engine.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,24 +56,24 @@ void Engine::resolveIds()
5656
{
5757
for (auto target : m_targets) {
5858
std::cout << "Processing target " << target->name() << "..." << std::endl;
59-
auto blocks = target->blocks();
59+
const auto &blocks = target->blocks();
6060
for (auto block : blocks) {
6161
auto container = blockSectionContainer(block->opcode());
6262
block->setNext(getBlock(block->nextId()));
6363
block->setParent(getBlock(block->parentId()));
6464
if (container)
6565
block->setCompileFunction(container->resolveBlockCompileFunc(block->opcode()));
6666

67-
auto inputs = block->inputs();
68-
for (auto input : inputs) {
67+
const auto &inputs = block->inputs();
68+
for (const auto &input : inputs) {
6969
input->setValueBlock(getBlock(input->valueBlockId()));
7070
if (container)
7171
input->setInputId(container->resolveInput(input->name()));
7272
input->primaryValue()->setValuePtr(getEntity(input->primaryValue()->valueId()));
7373
input->secondaryValue()->setValuePtr(getEntity(input->primaryValue()->valueId()));
7474
}
7575

76-
auto fields = block->fields();
76+
const auto &fields = block->fields();
7777
for (auto field : fields) {
7878
field->setValuePtr(getEntity(field->valueId()));
7979
if (container) {
@@ -107,7 +107,7 @@ void Engine::compile()
107107
std::cout << "Compiling scripts in target " << target->name() << "..." << std::endl;
108108
std::unordered_map<std::string, unsigned int *> procedureBytecodeMap;
109109
Compiler compiler(this, target.get());
110-
auto blocks = target->blocks();
110+
const auto &blocks = target->blocks();
111111
for (auto block : blocks) {
112112
if (block->topLevel() && !block->shadow()) {
113113
auto section = blockSection(block->opcode());

0 commit comments

Comments
 (0)