Fix dropdown menus in motion blocks

Author: adazem009

src/blocks/motionblocks.cpp

@@ -107,8 +107,7 @@ void MotionBlocks::compilePointTowards(Compiler *compiler)
 {
     Input *input = compiler->input(TOWARDS);
 
-    if (input->type() != Input::Type::ObscuredShadow) {
-        assert(input->pointsToDropdownMenu());
+    if (input->pointsToDropdownMenu()) {
         std::string value = input->selectedMenuItem();
 
         if (value == "_mouse_")
@@ -137,8 +136,7 @@ void MotionBlocks::compileGoTo(Compiler *compiler)
 {
     Input *input = compiler->input(TO);
 
-    if (input->type() != Input::Type::ObscuredShadow) {
-        assert(input->pointsToDropdownMenu());
+    if (input->pointsToDropdownMenu()) {
         std::string value = input->selectedMenuItem();
 
         if (value == "_mouse_")
@@ -171,8 +169,7 @@ void MotionBlocks::compileGlideTo(Compiler *compiler)
 
     Input *input = compiler->input(TO);
 
-    if (input->type() != Input::Type::ObscuredShadow) {
-        assert(input->pointsToDropdownMenu());
+    if (input->pointsToDropdownMenu()) {
         std::string value = input->selectedMenuItem();
 
         if (value == "_mouse_")

test/blocks/motion_blocks_test.cpp

@@ -74,6 +74,7 @@ class MotionBlocksTest : public testing::Test
             else {
                 auto input = addNullInput(block, name, id);
                 auto menu = createMotionBlock(block->id() + "_menu", block->opcode() + "_menu");
+                menu->setShadow(true);
                 input->setValueBlock(menu);
                 addDropdownField(menu, name, static_cast<MotionBlocks::Fields>(-1), selectedValue, static_cast<MotionBlocks::FieldValues>(-1));
             }