fix #358: Return by reference in IProjectReader

Author: adazem009

src/internal/iprojectreader.h

@@ -23,16 +23,16 @@ class IProjectReader
     public:
         virtual ~IProjectReader() { }
 
-        virtual std::string fileName() const final { return m_fileName; }
+        virtual const std::string &fileName() const final { return m_fileName; }
         virtual void setFileName(const std::string &fileName) final { m_fileName = fileName; }
 
         virtual bool load() = 0;
         virtual bool loadData(const std::string &data) = 0;
         virtual bool isValid() = 0;
         virtual void clear() = 0;
-        virtual std::vector<std::shared_ptr<Target>> targets() = 0;
-        virtual std::vector<std::shared_ptr<Broadcast>> broadcasts() = 0;
-        virtual std::vector<std::string> extensions() = 0;
+        virtual const std::vector<std::shared_ptr<Target>> &targets() = 0;
+        virtual const std::vector<std::shared_ptr<Broadcast>> &broadcasts() = 0;
+        virtual const std::vector<std::string> &extensions() = 0;
 
     protected:
         virtual void printErr(const std::string &errStr) final { std::cerr << "Failed to read project: " << errStr << std::endl; }

src/internal/scratch3reader.cpp

@@ -388,17 +388,17 @@ void Scratch3Reader::clear()
     m_extensions.clear();
 }
 
-std::vector<std::shared_ptr<Target>> Scratch3Reader::targets()
+const std::vector<std::shared_ptr<Target>> &Scratch3Reader::targets()
 {
     return m_targets;
 }
 
-std::vector<std::shared_ptr<Broadcast>> Scratch3Reader::broadcasts()
+const std::vector<std::shared_ptr<Broadcast>> &Scratch3Reader::broadcasts()
 {
     return m_broadcasts;
 }
 
-std::vector<std::string> Scratch3Reader::extensions()
+const std::vector<std::string> &Scratch3Reader::extensions()
 {
     return m_extensions;
 }

src/internal/scratch3reader.h

@@ -17,9 +17,9 @@ class Scratch3Reader : public IProjectReader
         bool loadData(const std::string &data) override;
         bool isValid() override;
         void clear() override;
-        std::vector<std::shared_ptr<Target>> targets() override;
-        std::vector<std::shared_ptr<Broadcast>> broadcasts() override;
-        std::vector<std::string> extensions() override;
+        const std::vector<std::shared_ptr<Target>> &targets() override;
+        const std::vector<std::shared_ptr<Broadcast>> &broadcasts() override;
+        const std::vector<std::string> &extensions() override;
 
     private:
         void read();