Fix NaN to double conversion

Author: adazem009

src/scratch/value_functions.cpp

@@ -222,9 +222,9 @@ extern "C"
     /*! Returns the double representation of the given value. */
     double value_toDouble(const libscratchcpp::ValueData *v)
     {
-        if (v->type == ValueType::Number)
-            return v->numberValue;
-        else if (v->type == ValueType::Bool)
+        if (v->type == ValueType::Number) {
+            return std::isnan(v->numberValue) ? 0 : v->numberValue;
+        } else if (v->type == ValueType::Bool)
             return v->boolValue;
         else if (v->type == ValueType::String)
             return value_stringToDouble(v->stringValue);

test/scratch_classes/value_test.cpp

@@ -981,6 +981,8 @@ TEST(ValueTest, ToDouble)
     ASSERT_TRUE(v.toDouble() < 0 && std::isinf(v.toDouble()));
     v = "NaN";
     ASSERT_EQ(v.toDouble(), 0.0);
+    v = std::numeric_limits<double>::quiet_NaN();
+    ASSERT_EQ(v.toDouble(), 0.0);
 
     v = "something";
     ASSERT_EQ(v.toDouble(), 0.0);