Merge pull request #226 from scratchcpp/sprite_direction_range

Fix #225: Fix sprite direction range

Author: adazem009

src/scratch/sprite.cpp

@@ -197,7 +197,13 @@ double Sprite::direction() const
 /*! Sets the direction. */
 void Sprite::setDirection(double newDirection)
 {
-    impl->direction = newDirection;
+    if (newDirection >= -180 && newDirection <= 180)
+        impl->direction = newDirection;
+    else if (newDirection < -180)
+        impl->direction = std::fmod(newDirection - 180, 360) + 180;
+    else
+        impl->direction = std::fmod(newDirection + 180, 360) - 180;
+
     if (impl->iface)
         impl->iface->onDirectionChanged(impl->direction);
 }

test/scratch_classes/sprite_test.cpp

@@ -225,6 +225,30 @@ TEST(SpriteTest, Direction)
 
     sprite.setDirection(145.2);
     ASSERT_EQ(sprite.direction(), 145.2);
+
+    sprite.setDirection(182.5);
+    ASSERT_EQ(sprite.direction(), -177.5);
+
+    sprite.setDirection(270);
+    ASSERT_EQ(sprite.direction(), -90);
+
+    sprite.setDirection(360);
+    ASSERT_EQ(sprite.direction(), 0);
+
+    sprite.setDirection(500);
+    ASSERT_EQ(sprite.direction(), 140);
+
+    sprite.setDirection(-182.5);
+    ASSERT_EQ(sprite.direction(), 177.5);
+
+    sprite.setDirection(-270);
+    ASSERT_EQ(sprite.direction(), 90);
+
+    sprite.setDirection(-360);
+    ASSERT_EQ(sprite.direction(), 0);
+
+    sprite.setDirection(-500);
+    ASSERT_EQ(sprite.direction(), -140);
 }
 
 TEST(SpriteTest, Draggable)