Add XPath tests for operator precedence

whybin · Gallaecio · commit c05327240d73 · 2019-10-21T15:50:13.000+02:00
diff --git a/tests/test_cssselect.py b/tests/test_cssselect.py
@@ -622,6 +622,11 @@ def xpath_attr_href_simple_pseudo_element(self, xpath):
                 other = XPathExpr('@href', '', )
                 return xpath.join('/', other)
 
+            # pseudo-element:
+            # used to demonstrate operator precedence
+            def xpath_first_or_second_pseudo(self, xpath):
+                return xpath.add_condition("@id = 'first' or @id = 'second'")
+
         def xpath(css):
             return _unicode(CustomTranslator().css_to_xpath(css))
 
@@ -633,6 +638,25 @@ def xpath(css):
         assert xpath('p img::attr(src)') == (
             "descendant-or-self::p/descendant-or-self::*/img/@src")
         assert xpath(':scope') == "descendant-or-self::*[1]"
+        assert xpath(':first-or-second[href]') == (
+            "descendant-or-self::*[(@id = 'first' or @id = 'second') "
+            "and (@href)]")
+
+        assert str(XPathExpr('', '', condition='@href')) == "[(@href)]"
+
+        document = etree.fromstring(OPERATOR_PRECEDENCE_IDS)
+        sort_key = dict(
+            (el, count) for count, el in enumerate(document.getiterator())
+        ).__getitem__
+        def operator_id(selector):
+            xpath = CustomTranslator().css_to_xpath(selector)
+            items = document.xpath(xpath)
+            items.sort(key=sort_key)
+            return [element.get('id', 'nil') for element in items]
+
+        assert operator_id(':first-or-second') == ['first', 'second']
+        assert operator_id(':first-or-second[href]') == ['second']
+        assert operator_id('[href]:first-or-second') == ['second']
 
     def test_series(self):
         def series(css):
@@ -935,6 +959,14 @@ def count(selector):
         assert count(':scope > div > div[class=dialog]') == 1
         assert count(':scope > div div') == 242
 
+OPERATOR_PRECEDENCE_IDS = '''
+<html>
+  <a id="first"></a>
+  <a id="second" href="#"></a>
+  <a id="third" href="#"></a>
+</html>
+'''
+
 XMLLANG_IDS = '''
 <test>
   <a id="first" xml:lang="en">a</a>
