Remove pytest-asyncio (#252)

Author: elacuesta

tests/tests_asyncio/test_browser_contexts.py

@@ -15,7 +15,6 @@
 
 
 class MixinTestCaseMultipleContexts:
-    @pytest.mark.asyncio
     async def test_context_kwargs(self):
         settings_dict = {
             "PLAYWRIGHT_BROWSER_TYPE": self.browser_type,
@@ -38,7 +37,6 @@ async def test_context_kwargs(self):
                 with pytest.raises(PlaywrightTimeoutError):
                     await handler._download_request(req, Spider("foo"))
 
-    @pytest.mark.asyncio
     async def test_contexts_max_pages(self):
         settings = {
             "PLAYWRIGHT_BROWSER_TYPE": self.browser_type,
@@ -73,7 +71,6 @@ async def test_contexts_max_pages(self):
 
             assert handler.stats.get_value("playwright/page_count/max_concurrent") == 4
 
-    @pytest.mark.asyncio
     async def test_max_contexts(self):
         def cb_close_context(task):
             response = task.result()
@@ -108,7 +105,6 @@ def cb_close_context(task):
 
             assert handler.stats.get_value("playwright/context_count/max_concurrent") == 4
 
-    @pytest.mark.asyncio
     async def test_contexts_startup(self):
         settings = {
             "PLAYWRIGHT_BROWSER_TYPE": self.browser_type,
@@ -147,7 +143,6 @@ async def test_contexts_startup(self):
             assert cookie["value"] == "bar"
             assert cookie["domain"] == "example.org"
 
-    @pytest.mark.asyncio
     async def test_persistent_context(self):
         temp_dir = f"{tempfile.gettempdir()}/{uuid4()}"
         settings = {
@@ -166,7 +161,6 @@ async def test_persistent_context(self):
             assert handler.context_wrappers["persistent"].persistent
             assert not hasattr(handler, "browser")
 
-    @pytest.mark.asyncio
     async def test_mixed_persistent_contexts(self):
         temp_dir = f"{tempfile.gettempdir()}/{uuid4()}"
         settings = {
@@ -189,7 +183,6 @@ async def test_mixed_persistent_contexts(self):
             assert not handler.context_wrappers["non-persistent"].persistent
             assert isinstance(handler.browser, Browser)
 
-    @pytest.mark.asyncio
     async def test_contexts_dynamic(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             assert len(handler.context_wrappers) == 0

tests/tests_asyncio/test_headers.py

@@ -10,7 +10,6 @@
 
 
 class MixinProcessHeadersTestCase:
-    @pytest.mark.asyncio
     async def test_user_agent(self):
         settings_dict = {
             "PLAYWRIGHT_BROWSER_TYPE": self.browser_type,
@@ -40,7 +39,6 @@ async def test_user_agent(self):
                 headers = {key.lower(): value for key, value in headers.items()}
                 assert headers["user-agent"] == "foobar"
 
-    @pytest.mark.asyncio
     async def test_playwright_headers(self):
         """Ignore Scrapy headers"""
         settings_dict = {
@@ -65,7 +63,6 @@ async def test_playwright_headers(self):
                 assert "asdf" not in req.headers
                 assert b"asdf" not in req.headers
 
-    @pytest.mark.asyncio
     async def test_use_custom_headers(self):
         """Custom header processing function"""
 

tests/tests_asyncio/test_page_methods.py

@@ -24,7 +24,6 @@ def get_mimetype(file):
 
 
 class TestPageMethods(IsolatedAsyncioTestCase):
-    @pytest.mark.asyncio
     async def test_page_methods(self):
         screenshot = PageMethod("screenshot", "foo", 123, path="/tmp/file", type="png")
         assert screenshot.method == "screenshot"
@@ -40,7 +39,6 @@ def inject_fixtures(self, caplog):
         caplog.set_level(logging.DEBUG)
         self._caplog = caplog
 
-    @pytest.mark.asyncio
     async def test_page_non_page_method(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with StaticMockServer() as server:
@@ -65,7 +63,6 @@ async def test_page_non_page_method(self):
                 f"Ignoring {repr(obj)}: expected PageMethod, got {repr(type(obj))}",
             ) in self._caplog.record_tuples
 
-    @pytest.mark.asyncio
     async def test_page_mixed_page_methods(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with StaticMockServer() as server:
@@ -92,7 +89,6 @@ async def test_page_mixed_page_methods(self):
         assert not req.meta["playwright_page_methods"]["is_closed"].result
         assert req.meta["playwright_page_methods"]["title"].result == "Awesome site"
 
-    @pytest.mark.asyncio
     async def test_page_method_navigation(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with StaticMockServer() as server:
@@ -114,7 +110,6 @@ async def test_page_method_navigation(self):
             text = resp.css("p::text").get()
             assert text == "Lorem ipsum dolor sit amet, consectetur adipiscing elit."
 
-    @pytest.mark.asyncio
     async def test_page_method_infinite_scroll(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with StaticMockServer() as server:
@@ -141,7 +136,6 @@ async def test_page_method_infinite_scroll(self):
             assert_correct_response(resp, req)
             assert len(resp.css("div.quote")) == 30
 
-    @pytest.mark.asyncio
     async def test_page_method_screenshot(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with NamedTemporaryFile(mode="w+b") as png_file:
@@ -161,7 +155,6 @@ async def test_page_method_screenshot(self):
                 assert png_file.file.read() == req.meta["playwright_page_methods"]["png"].result
                 assert get_mimetype(png_file) == "image/png"
 
-    @pytest.mark.asyncio
     async def test_page_method_pdf(self):
         if self.browser_type != "chromium":
             pytest.skip("PDF generation is supported only in Chromium")

tests/tests_asyncio/test_playwright_requests.py

@@ -41,7 +41,6 @@ def inject_fixtures(self, caplog):
         caplog.set_level(logging.DEBUG)
         self._caplog = caplog
 
-    @pytest.mark.asyncio
     async def test_basic_response(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with StaticMockServer() as server:
@@ -53,10 +52,8 @@ async def test_basic_response(self):
             assert resp.css("a::text").getall() == ["Lorem Ipsum", "Infinite Scroll"]
             assert isinstance(resp.meta["playwright_page"], PlaywrightPage)
             assert resp.meta["playwright_page"].url == resp.url
-
             await resp.meta["playwright_page"].close()
 
-    @pytest.mark.asyncio
     async def test_post_request(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with MockServer() as server:
@@ -68,7 +65,6 @@ async def test_post_request(self):
             assert_correct_response(resp, req)
             assert "Request body: foo=bar" in resp.text
 
-    @pytest.mark.asyncio
     async def test_timeout_error(self):
         settings_dict = {
             "PLAYWRIGHT_BROWSER_TYPE": self.browser_type,
@@ -86,7 +82,6 @@ async def test_timeout_error(self):
                     f" exc_type={type(excinfo.value)} exc_msg={str(excinfo.value)}",
                 ) in self._caplog.record_tuples
 
-    @pytest.mark.asyncio
     async def test_retry_page_content_still_navigating(self):
         if self.browser_type != "chromium":
             pytest.skip("Only Chromium seems to redirect meta tags within the same goto call")
@@ -108,7 +103,6 @@ async def test_retry_page_content_still_navigating(self):
             ) in self._caplog.record_tuples
 
     @patch("scrapy_playwright.handler.logger")
-    @pytest.mark.asyncio
     async def test_route_continue_exception(self, logger):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             scrapy_request = Request(url="https://example.org", method="GET")
@@ -159,7 +153,6 @@ async def test_route_continue_exception(self, logger):
             with pytest.raises(PlaywrightError):
                 await req_handler(route, playwright_request)
 
-    @pytest.mark.asyncio
     async def test_event_handler_dialog_callable(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with StaticMockServer() as server:
@@ -181,7 +174,6 @@ async def test_event_handler_dialog_callable(self):
 
             assert spider.dialog_message == "foobar"
 
-    @pytest.mark.asyncio
     async def test_event_handler_dialog_str(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with StaticMockServer() as server:
@@ -203,7 +195,6 @@ async def test_event_handler_dialog_str(self):
 
             assert spider.dialog_message == "foobar"
 
-    @pytest.mark.asyncio
     async def test_event_handler_dialog_missing(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with StaticMockServer() as server:
@@ -227,7 +218,6 @@ async def test_event_handler_dialog_missing(self):
         ) in self._caplog.record_tuples
         assert getattr(spider, "dialog_message", None) is None
 
-    @pytest.mark.asyncio
     async def test_response_attributes(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with MockServer() as server:
@@ -239,7 +229,6 @@ async def test_response_attributes(self):
 
         assert response.ip_address == ip_address(server.address)
 
-    @pytest.mark.asyncio
     async def test_page_goto_kwargs_referer(self):
         if self.browser_type != "chromium":
             pytest.skip("referer as goto kwarg seems to work only with chromium :shrug:")
@@ -258,7 +247,6 @@ async def test_page_goto_kwargs_referer(self):
         headers = json.loads(response.css("pre::text").get())
         assert headers["Referer"] == fake_referer
 
-    @pytest.mark.asyncio
     async def test_navigation_returns_none(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with MockServer():
@@ -274,7 +262,6 @@ async def test_navigation_returns_none(self):
         assert not response.headers
         assert response.status == 200
 
-    @pytest.mark.asyncio
     async def test_abort_requests(self):
         async def should_abort_request_async(request):
             return request.resource_type == "image"
@@ -307,7 +294,6 @@ def should_abort_request_sync(request):
                     assert handler.stats.get_value(f"{resp_prefix}/resource_type/image") is None
                     assert handler.stats.get_value(f"{req_prefix}/aborted") == 3
 
-    @pytest.mark.asyncio
     async def test_page_initialization_ok(self):
         async def init_page(page, _request):
             await page.set_extra_http_headers({"Extra-Header": "Qwerty"})
@@ -328,7 +314,6 @@ async def init_page(page, _request):
         headers = {key.lower(): value for key, value in headers.items()}
         assert headers["extra-header"] == "Qwerty"
 
-    @pytest.mark.asyncio
     async def test_page_initialization_fail(self):
         async def init_page(page, _request, _missing):
             await page.set_extra_http_headers({"Extra-Header": "Qwerty"})
@@ -355,7 +340,6 @@ async def init_page(page, _request, _missing):
                 assert f"[Context=default] Page init callback exception for {req!r}" in entry[2]
                 assert "init_page() missing 1 required positional argument: '_missing'" in entry[2]
 
-    @pytest.mark.asyncio
     async def test_redirect(self):
         async with make_handler({"PLAYWRIGHT_BROWSER_TYPE": self.browser_type}) as handler:
             with MockServer() as server:
@@ -373,7 +357,6 @@ async def test_redirect(self):
             server.urljoin("/redirect"),
         ]
 
-    @pytest.mark.asyncio
     async def test_logging_record_spider(self):
         """Make sure at least one log record has the spider as an attribute
         (records sent before opening the spider will not have it).
@@ -386,7 +369,6 @@ async def test_logging_record_spider(self):
 
         assert any(getattr(rec, "spider", None) is spider for rec in self._caplog.records)
 
-    @pytest.mark.asyncio
     async def test_download_file(self):
         settings_dict = {
             "PLAYWRIGHT_BROWSER_TYPE": self.browser_type,
@@ -402,7 +384,6 @@ async def test_download_file(self):
                 assert response.body.startswith(b"%PDF-1.5")
                 assert handler.stats.get_value("playwright/download_count") == 1
 
-    @pytest.mark.asyncio
     async def test_download_file_delay_ok(self):
         settings_dict = {
             "PLAYWRIGHT_BROWSER_TYPE": self.browser_type,
@@ -419,7 +400,6 @@ async def test_download_file_delay_ok(self):
                 assert response.body.startswith(b"%PDF-1.5")
                 assert handler.stats.get_value("playwright/download_count") == 1
 
-    @pytest.mark.asyncio
     async def test_download_file_delay_error(self):
         settings_dict = {
             "PLAYWRIGHT_BROWSER_TYPE": self.browser_type,
@@ -440,7 +420,6 @@ async def test_download_file_delay_error(self):
                     f" exc_type={type(excinfo.value)} exc_msg={str(excinfo.value)}",
                 ) in self._caplog.record_tuples
 
-    @pytest.mark.asyncio
     async def test_download_file_failure(self):
         if self.browser_type != "chromium":
             pytest.skip()

tests/tests_asyncio/test_utils.py

@@ -22,7 +22,6 @@ def inject_fixtures(self, caplog):
         caplog.set_level(logging.DEBUG)
         self._caplog = caplog
 
-    @pytest.mark.asyncio
     async def test_get_page_content_ok(self):
         expected_content = "lorem ipsum"
         page = AsyncMock()
@@ -36,7 +35,6 @@ async def test_get_page_content_ok(self):
         )
         assert content == expected_content
 
-    @pytest.mark.asyncio
     async def test_get_page_content_retry_known_exception(self):
         expected_content = "lorem ipsum"
         page = AsyncMock()
@@ -57,7 +55,6 @@ async def test_get_page_content_retry_known_exception(self):
             " content because the page is navigating and changing the content.'",
         ) in self._caplog.record_tuples
 
-    @pytest.mark.asyncio
     async def test_get_page_content_reraise_unknown_exception(self):
         expected_exception_message = "nope"
         page = AsyncMock()
@@ -87,7 +84,6 @@ def body_str(charset: str, content: str = "áéíóú") -> str:
             </html>
         """.strip()
 
-    @pytest.mark.asyncio
     async def test_encode_from_headers(self):
         """Charset declared in headers takes precedence"""
         text = self.body_str(charset="gb2312")
@@ -98,23 +94,20 @@ async def test_encode_from_headers(self):
         assert encoding == "cp1252"
         assert body == text.encode(encoding)
 
-    @pytest.mark.asyncio
     async def test_encode_from_body(self):
         """No charset declared in headers, use the one declared in the body"""
         text = self.body_str(charset="gb2312")
         body, encoding = _encode_body(headers=Headers({}), text=text)
         assert encoding == "gb18030"
         assert body == text.encode(encoding)
 
-    @pytest.mark.asyncio
     async def test_encode_fallback_utf8(self):
         """No charset declared, use utf-8 as fallback"""
         text = "<html>áéíóú</html>"
         body, encoding = _encode_body(headers=Headers(), text=text)
         assert encoding == "utf-8"
         assert body == text.encode(encoding)
 
-    @pytest.mark.asyncio
     async def test_encode_mismatch(self):
         """Charset declared in headers and body do not match, and the headers
         one fails to encode: use the one in the body (first one that works)
@@ -129,7 +122,6 @@ async def test_encode_mismatch(self):
 
 
 class TestHeaderValue(IsolatedAsyncioTestCase):
-    @pytest.mark.asyncio
     async def test_get_header_ok(self):
         async def _identity(x):
             return x
@@ -147,7 +139,6 @@ async def test_get_header_exception(self):
 
 
 class TestMaybeAwait(IsolatedAsyncioTestCase):
-    @pytest.mark.asyncio
     async def test_maybe_await(self):
         async def _awaitable_identity(x):
             return x

tox.ini

@@ -4,7 +4,6 @@ envlist = bandit,black,flake8,typing,pylint,py,py-twisted
 [testenv]
 deps =
     pytest==7.4.0
-    pytest_asyncio==0.21.1
     pytest_cov==4.1.0
     pytest_twisted==1.14
 commands =