Skip to content

Commit 1c5f96e

Browse files
committed
Update readme: known issues
1 parent 268e533 commit 1c5f96e

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

README.md

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -581,14 +581,25 @@ class ScrollSpider(scrapy.Spider):
581581
For more examples, please see the scripts in the [examples](examples) directory.
582582

583583

584-
## Known limitations
584+
## Known issues
585585

586-
* This package does not work out-of-the-box on Windows. See
587-
[#7](https://github.com/scrapy-plugins/scrapy-playwright/issues/7)
588-
(specifically [this comment](https://github.com/scrapy-plugins/scrapy-playwright/issues/7#issuecomment-808824121))
589-
for an explanation. Note that it seems to be possible to
590-
[run under WSL](https://github.com/scrapy-plugins/scrapy-playwright/issues/7#issuecomment-817394494).
586+
* `scrapy-playwright` does not work out-of-the-box on Windows. From the
587+
[playwright docs](https://playwright.dev/python/docs/intro#incompatible-with-selectoreventloop-of-asyncio-on-windows):
591588

589+
> Playwright runs the driver in a subprocess, so it requires
590+
> ProactorEventLoop of asyncio on Windows because SelectorEventLoop
591+
> does not supports async subprocesses.
592+
593+
Also, from the [Python docs](https://docs.python.org/3/library/asyncio-platforms.html#asyncio-windows-subprocess):
594+
595+
> On Windows, the default event loop ProactorEventLoop supports subprocesses,
596+
> whereas SelectorEventLoop does not.
597+
598+
However, Twisted's `asyncio` reactor runs on top of `SelectorEventLoop`
599+
([source](https://github.com/twisted/twisted/blob/twisted-22.4.0/src/twisted/internet/asyncioreactor.py#L31)).
600+
601+
Some users have reported having success
602+
[running under WSL](https://github.com/scrapy-plugins/scrapy-playwright/issues/7#issuecomment-817394494).
592603
See also [#78](https://github.com/scrapy-plugins/scrapy-playwright/issues/78)
593604
for information about working in headful mode under WSL.
594605

0 commit comments

Comments
 (0)