Skip to content

Commit 14da796

Browse files
committed
Readme: update known issues section
1 parent ee55049 commit 14da796

File tree

1 file changed

+24
-22
lines changed

1 file changed

+24
-22
lines changed

README.md

Lines changed: 24 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -732,28 +732,30 @@ For more examples, please see the scripts in the [examples](examples) directory.
732732

733733
## Known issues
734734

735-
* `scrapy-playwright` does not work out-of-the-box on Windows. From the
736-
[playwright docs](https://playwright.dev/python/docs/intro#incompatible-with-selectoreventloop-of-asyncio-on-windows):
737-
738-
> Playwright runs the driver in a subprocess, so it requires
739-
> ProactorEventLoop of asyncio on Windows because SelectorEventLoop
740-
> does not supports async subprocesses.
741-
742-
Also, from the [Python docs](https://docs.python.org/3/library/asyncio-platforms.html#asyncio-windows-subprocess):
743-
744-
> On Windows, the default event loop ProactorEventLoop supports subprocesses,
745-
> whereas SelectorEventLoop does not.
746-
747-
However, Twisted's `asyncio` reactor runs on top of `SelectorEventLoop`
748-
([source](https://github.com/twisted/twisted/blob/twisted-22.4.0/src/twisted/internet/asyncioreactor.py#L31)).
749-
750-
Some users have reported having success
751-
[running under WSL](https://github.com/scrapy-plugins/scrapy-playwright/issues/7#issuecomment-817394494).
752-
See also [#78](https://github.com/scrapy-plugins/scrapy-playwright/issues/78)
753-
for information about working in headful mode under WSL.
754-
755-
* Specifying a proxy via the `proxy` Request meta key is not supported.
756-
Refer to the [Proxy support](#proxy-support) section for more information.
735+
### Lack of native support for Windows
736+
737+
This package does not work natively on Windows. This is because:
738+
739+
* Playwright runs the driver in a subprocess. Source:
740+
[Playwright repository](https://github.com/microsoft/playwright-python/blob/v1.28.0/playwright/_impl/_transport.py#L120-L129).
741+
* "On Windows, the default event loop `ProactorEventLoop` supports subprocesses,
742+
whereas `SelectorEventLoop` does not". Source:
743+
[Python docs](https://docs.python.org/3/library/asyncio-platforms.html#asyncio-windows-subprocess).
744+
* Twisted's `asyncio` reactor requires the `SelectorEventLoop`. Source:
745+
[Twisted repository](https://github.com/twisted/twisted/blob/twisted-22.4.0/src/twisted/internet/asyncioreactor.py#L31).
746+
747+
Some users have reported having success
748+
[running under WSL](https://github.com/scrapy-plugins/scrapy-playwright/issues/7#issuecomment-817394494).
749+
See also [#78](https://github.com/scrapy-plugins/scrapy-playwright/issues/78)
750+
for information about working in headful mode under WSL.
751+
752+
### No per-request proxy support
753+
Specifying a proxy via the `proxy` Request meta key is not supported.
754+
Refer to the [Proxy support](#proxy-support) section for more information.
755+
756+
### Unsopported signals
757+
The `headers_received` and `bytes_received` signals are not fired by the
758+
scrapy-playwright download handler.
757759

758760

759761
## Deprecation policy

0 commit comments

Comments
 (0)