Skip to content

Commit a06beac

Browse files
committed
Removed dependencies on commons-io
1 parent 01a3e87 commit a06beac

File tree

9 files changed

+16
-20
lines changed

9 files changed

+16
-20
lines changed

project/Scoverage.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,8 @@ object Scoverage extends Build {
7676
.settings(name := "scalac-scoverage-plugin")
7777
.settings(appSettings: _*)
7878
.settings(libraryDependencies ++= Seq(
79-
"commons-io" % "commons-io" % "2.4",
80-
"org.scala-lang" % "scala-reflect" % scalaVersion.value,
81-
"org.scala-lang" % "scala-compiler" % scalaVersion.value,
79+
"org.scala-lang" % "scala-reflect" % scalaVersion.value % "provided",
80+
"org.scala-lang" % "scala-compiler" % scalaVersion.value % "provided",
8281
"org.joda" % "joda-convert" % "1.6" % "test",
8382
"joda-time" % "joda-time" % "2.3" % "test",
8483
"com.typesafe.scala-logging" %% "scala-logging-slf4j" % "2.1.2" % "test"

scalac-scoverage-plugin/src/main/scala/scoverage/IOUtils.scala

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ import scala.io.Source
1010
/** @author Stephen Samuel */
1111
object IOUtils {
1212

13+
def getTempDirectory: File = new File(getTempPath)
14+
def getTempPath: String = System.getProperty("java.io.tmpdir")
15+
1316
def readStreamAsString(in: InputStream): String = Source.fromInputStream(in).mkString
1417

1518
private val UnixSeperator: Char = '/'

scalac-scoverage-plugin/src/main/scala/scoverage/report/CoberturaXmlWriter.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ package scoverage.report
22

33
import java.io.File
44

5-
import _root_.scoverage.{Coverage, MeasuredClass, MeasuredMethod, MeasuredPackage}
6-
import org.apache.commons.io.FileUtils
5+
import scoverage._
76

87
import scala.xml.Node
98

@@ -13,7 +12,7 @@ class CoberturaXmlWriter(baseDir: File, outputDir: File) {
1312
def format(double: Double): String = "%.2f".format(double)
1413

1514
def write(coverage: Coverage): Unit = {
16-
FileUtils.write(new File(outputDir.getAbsolutePath + "/cobertura.xml"),
15+
IOUtils.writeToFile(new File(outputDir.getAbsolutePath + "/cobertura.xml"),
1716
"<?xml version=\"1.0\"?>\n<!DOCTYPE coverage SYSTEM \"http://cobertura.sourceforge.net/xml/coverage-04.dtd\">\n" +
1817
xml(coverage))
1918
}

scalac-scoverage-plugin/src/main/scala/scoverage/report/ScoverageXmlWriter.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package scoverage.report
33
import java.io.File
44

55
import _root_.scoverage._
6-
import org.apache.commons.io.FileUtils
76

87
import scala.xml.{Node, PrettyPrinter}
98

@@ -15,7 +14,7 @@ class ScoverageXmlWriter(sourceDir: File, outputDir: File, debug: Boolean) {
1514
case true => new File(outputDir.getAbsolutePath + "/scoverage-debug.xml")
1615
case false => new File(outputDir.getAbsolutePath + "/" + Constants.XMLReportFilename)
1716
}
18-
FileUtils.write(file, new PrettyPrinter(120, 4).format(xml(coverage)))
17+
IOUtils.writeToFile(file, new PrettyPrinter(120, 4).format(xml(coverage)))
1918
}
2019

2120
def statement(stmt: Statement): Node = {

scalac-scoverage-plugin/src/main/scala/scoverage/report/SourceHighlighter.scala

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
package scoverage.report
22

3-
import java.io.{File, FileInputStream}
4-
53
import _root_.scoverage.MeasuredFile
6-
import org.apache.commons.io.IOUtils
74

5+
import scala.io.Source
86
import scala.xml.{Node, Unparsed}
97

108
/** @author Stephen Samuel */
119
class SourceHighlighter {
1210

1311
val sep = System.getProperty("line.separator")
1412

15-
def source(mfile: MeasuredFile) = IOUtils.toString(new FileInputStream(new File(mfile.source)), "UTF-8")
13+
def source(mfile: MeasuredFile) = Source.fromFile(mfile.source).mkString
1614

1715
def print(mfile: MeasuredFile): Node = {
1816
val s = source(mfile)

scalac-scoverage-plugin/src/test/scala/scoverage/CoberturaXmlWriterTest.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import java.io.File
44
import java.util.UUID
55
import javax.xml.parsers.DocumentBuilderFactory
66

7-
import org.apache.commons.io.FileUtils
87
import org.scalatest.{BeforeAndAfter, FunSuite, OneInstancePerTest}
98
import org.xml.sax.{ErrorHandler, SAXParseException}
109
import scoverage.report.CoberturaXmlWriter
@@ -15,7 +14,7 @@ import scala.xml.XML
1514
class CoberturaXmlWriterTest extends FunSuite with BeforeAndAfter with OneInstancePerTest {
1615

1716
def tempDir(): File = {
18-
val dir = new File(FileUtils.getTempDirectory, UUID.randomUUID().toString)
17+
val dir = new File(IOUtils.getTempDirectory, UUID.randomUUID().toString)
1918
dir.mkdirs()
2019
dir.deleteOnExit()
2120
dir

scalac-scoverage-plugin/src/test/scala/scoverage/IOUtilsTest.scala

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@ package scoverage
33
import java.io.{File, FileWriter}
44
import java.util.UUID
55

6-
import org.apache.commons.io.FileUtils
76
import org.scalatest.mock.MockitoSugar
8-
import org.scalatest.{Matchers, FreeSpec, OneInstancePerTest}
7+
import org.scalatest.{FreeSpec, Matchers, OneInstancePerTest}
98

109
/** @author Stephen Samuel */
1110
class IOUtilsTest extends FreeSpec with MockitoSugar with OneInstancePerTest with Matchers {
@@ -23,7 +22,7 @@ class IOUtilsTest extends FreeSpec with MockitoSugar with OneInstancePerTest wit
2322
}
2423
"should parse multiple measurement files" in {
2524
// clean up any existing measurement files
26-
for ( file <- IOUtils.findMeasurementFiles(FileUtils.getTempDirectoryPath) )
25+
for ( file <- IOUtils.findMeasurementFiles(IOUtils.getTempDirectory) )
2726
file.delete()
2827

2928
val file1 = File.createTempFile("scoverage.measurements.1", "txt")
@@ -45,7 +44,7 @@ class IOUtilsTest extends FreeSpec with MockitoSugar with OneInstancePerTest wit
4544
}
4645
"should deep search for report files" in {
4746
// create new folder to hold all our data
48-
val base = new File(FileUtils.getTempDirectoryPath + "/" + UUID.randomUUID)
47+
val base = new File(IOUtils.getTempDirectory, UUID.randomUUID.toString)
4948
base.mkdir() shouldBe true
5049

5150
val file1 = new File(base + "/" + Constants.XMLReportFilename)

scalac-scoverage-plugin/src/test/scala/scoverage/LocationCompiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class LocationCompiler(settings: scala.tools.nsc.Settings, reporter: scala.tools
2020

2121
def writeCodeSnippetToTempFile(code: String): File = {
2222
val file = File.createTempFile("code_snippet", ".scala")
23-
org.apache.commons.io.FileUtils.write(file, code)
23+
IOUtils.writeToFile(file, code)
2424
file.deleteOnExit()
2525
file
2626
}

scalac-scoverage-plugin/src/test/scala/scoverage/compiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ class ScoverageCompiler(settings: scala.tools.nsc.Settings, reporter: scala.tool
8484

8585
def writeCodeSnippetToTempFile(code: String): File = {
8686
val file = File.createTempFile("scoverage_snippet", ".scala")
87-
org.apache.commons.io.FileUtils.write(file, code)
87+
IOUtils.writeToFile(file, code)
8888
file.deleteOnExit()
8989
file
9090
}

0 commit comments

Comments
 (0)