Skip to content

Commit a1c6055

Browse files
add error case for apply addons
1 parent a230b53 commit a1c6055

File tree

1 file changed

+26
-8
lines changed

1 file changed

+26
-8
lines changed

minikube/service/minikube_client_test.go

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -530,22 +530,40 @@ func TestMinikubeClient_ApplyAddons(t *testing.T) {
530530
deleteAddons: []string{"feature1", "feature2"},
531531
addAddons: []string{"feature3"},
532532
},
533+
{
534+
name: "Should return err if addon cannot be set",
535+
fields: fields{
536+
clusterName: "cluster",
537+
addons: []string{"feature1", "feature2"},
538+
TfCreationLock: &sync.Mutex{},
539+
},
540+
args: args{
541+
addons: []string{"feature3"},
542+
},
543+
wantErr: true,
544+
},
533545
}
534546
for _, tt := range tests {
535547
t.Run(tt.name, func(t *testing.T) {
536548
ctrl := gomock.NewController(t)
537549
mockNode := NewMockCluster(ctrl)
538550
delSeq := make([]*gomock.Call, 0)
539551
addSeq := make([]*gomock.Call, 0)
540-
for _, deleteAddon := range tt.deleteAddons {
552+
if tt.wantErr {
541553
delSeq = append(delSeq, mockNode.EXPECT().
542-
SetAddon("cluster", deleteAddon, "false").
543-
Return(nil))
544-
}
545-
for _, addAddon := range tt.addAddons {
546-
addSeq = append(addSeq, mockNode.EXPECT().
547-
SetAddon("cluster", addAddon, "true").
548-
Return(nil))
554+
SetAddon(gomock.Any(), gomock.Any(), gomock.Any()).
555+
Return(errors.New("error")))
556+
} else {
557+
for _, deleteAddon := range tt.deleteAddons {
558+
delSeq = append(delSeq, mockNode.EXPECT().
559+
SetAddon("cluster", deleteAddon, "false").
560+
Return(nil))
561+
}
562+
for _, addAddon := range tt.addAddons {
563+
addSeq = append(addSeq, mockNode.EXPECT().
564+
SetAddon("cluster", addAddon, "true").
565+
Return(nil))
566+
}
549567
}
550568
gomock.InAnyOrder(append(delSeq, addSeq...))
551569

0 commit comments

Comments
 (0)