refactor(modinfo): deprecate in favor of upstream one in >= 35

evelikov · evelikov · commit 61a01e90610b · 2024-11-08T16:25:51.000Z
There isn't an equivalent merged upstream, yet, so use "expected to" wording. Issue: #1246 Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
diff --git a/completions/Makefile.am b/completions/Makefile.am
@@ -268,7 +268,7 @@ bashcomp_DATA = 2to3 \
 		mktemp \
 		mmsitepass \
 		_mock \
-		modinfo \
+		_modinfo \
 		modprobe \
 		_modules \
 		monodevelop \
diff --git a/completions/_modinfo b/completions/_modinfo
@@ -1,5 +1,8 @@
 # Linux modinfo(8) completion                              -*- shell-script -*-
 
+# Use of this file is deprecated.
+# Upstream completion is expected to be available in kmod >= 35, use that instead.
+
 _comp_cmd_modinfo()
 {
     local cur prev words cword was_split comp_args
diff --git a/test/fallback/completions/Makefile.am b/test/fallback/completions/Makefile.am
@@ -21,6 +21,7 @@ EXTRA_DIST = \
 	look \
 	mdbook \
 	mock \
+	modinfo \
 	modules \
 	mount \
 	mount.linux \
diff --git a/test/fallback/completions/modinfo b/test/fallback/completions/modinfo
@@ -0,0 +1 @@
+../../../completions/_modinfo

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,8 @@`
`1`	`1`	`# Linux modinfo(8) completion -- shell-script --`
`2`	`2`
	`3`	`+# Use of this file is deprecated.`
	`4`	`+# Upstream completion is expected to be available in kmod >= 35, use that instead.`
	`5`	`+`
`3`	`6`	`_comp_cmd_modinfo()`
`4`	`7`	`{`
`5`	`8`	`local cur prev words cword was_split comp_args`