Fix usage of BranchResolver on Unsupported Repo Types

This fixes a problem on SVN Repos that throws an error to the client on commits (because BranchResolver is not working on SVN Repos).

Author: Shaoranlaos

gradle/changelog/fix_svn_post_commit_hook.yaml

@@ -0,0 +1,2 @@
+- type: fixed
+  description: Fix failing post-commit Hook on SVN Repository, because it does not support the BranchResolver (call leads to visible error on client side)

src/main/java/com/cloudogu/scm/review/pullrequest/service/PullRequestSuggestionService.java

@@ -70,9 +70,14 @@ public void onBranchUpdated(PostReceiveRepositoryHookEvent event) {
     Repository repository = event.getRepository();
 
     boolean isNotSupported = !pullRequestService.supportsPullRequests(repository);
-    boolean isSingleOrNoBranch = branchResolver.getAll(repository).size() < 2;
+    if (isNotSupported) {
+      return;
+    }
 
-    if (isNotSupported || isSingleOrNoBranch) {
+    // check the branches only if PullRequests support (abort before branch check)
+    // because BranchResolver throws an error to the client if the repository type does not support branches
+    boolean isSingleOrNoBranch = branchResolver.getAll(repository).size() < 2;
+    if (isSingleOrNoBranch) {
       return;
     }
 

src/test/java/com/cloudogu/scm/review/pullrequest/service/PullRequestSuggestionServiceTest.java

@@ -47,6 +47,7 @@
 import java.util.List;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.lenient;
 import static org.mockito.Mockito.when;
 
 @ExtendWith({MockitoExtension.class, ShiroExtension.class})
@@ -78,10 +79,10 @@ class OnBranchPushed {
     @BeforeEach
     void setup() {
       when(pullRequestService.supportsPullRequests(repository)).thenReturn(true);
-      when(hookContext.getBranchProvider().getCreatedOrModified()).thenReturn(
+      lenient().when(hookContext.getBranchProvider().getCreatedOrModified()).thenReturn(
         List.of("feature")
       );
-      when(branchResolver.getAll(repository)).thenReturn(List.of(
+      lenient().when(branchResolver.getAll(repository)).thenReturn(List.of(
         Branch.defaultBranch(
           "main",
           "revisionOnMain",
@@ -108,7 +109,10 @@ private PostReceiveRepositoryHookEvent createPostReceiveRepositoryHookEvent() {
     @Test
     void shouldIgnorePushBecauseRepositoryDoesNotSupportPullRequests() {
       when(pullRequestService.supportsPullRequests(repository)).thenReturn(false);
+      lenient().when(branchResolver.getAll(repository)).thenThrow(InternalRepositoryException.class);
+
       suggestionService.onBranchUpdated(createPostReceiveRepositoryHookEvent());
+
       assertThat(suggestionService.getPushEntries()).isEmpty();
     }