ISO8601-time

Author: scivision

README.md

@@ -1,7 +1,7 @@
 # mozilla-location-python
 Uses nmcli on Linux in a short, simple Mozilla Location Services with Wifi from Python.
 Goal was to be as simple as possible.
-Works with Python 2.7 and 3.
+Works with Python ≥ 3.6.
 
 ## Install
 ```sh
@@ -15,7 +15,7 @@ Linux system with NetworkManager (e.g. Ubuntu, Raspberry Pi, etc.).
 
 ## Usage
 
-    ./mozloc.py
+    ./MozLoc.py
 
 Returns `dict` containing `lat` `lng` `accuracy` `N BSSIDs heard`.
 In urban areas, accuracy ~ 5 - 100 meters.
@@ -29,6 +29,11 @@ You can display your logged data in Google Earth or other KML value after conver
 with
 
     pip install simplekml
+    
+Note that your time MUST be in ISO 8601 format or some KML reading programs such as Google Earth will just show a blank file.
+E.g.
+
+2016-07-24T12:34:56
 
 
 ## Contributing

mozloc/__init__.py

@@ -13,7 +13,7 @@
 NMSCAN = ['nmcli','device','wifi','rescan']
 HEADER='time lat lon accuracy NumBSSIDs'
 
-
+# %%
 def logwifiloc(T:float, logfile:Path):
 
     if logfile:
@@ -30,7 +30,7 @@ def logwifiloc(T:float, logfile:Path):
             sleep(T)
             continue
 
-        stat = f'{loc["t"].strftime("%xT%X")} {loc["lat"]} {loc["lng"]} {loc["accuracy"]:.1f} {loc["N"]:02d}'
+        stat = f'{loc["t"].isoformat(timespec="seconds")} {loc["lat"]} {loc["lng"]} {loc["accuracy"]:.1f} {loc["N"]:02d}'
         print(stat)
 
         if logfile:
@@ -39,14 +39,14 @@ def logwifiloc(T:float, logfile:Path):
 
         sleep(T)
 
-
+# %%
 def get_nmcli():
 
 
-    ret = subprocess.check_output(NMLEG, universal_newlines=True)
+    ret = subprocess.check_output(NMLEG, universal_newlines=True, timeout=1.)
     sleep(0.5) # nmcli crashed for less than about 0.2 sec.
     try:
-        subprocess.check_call(NMSCAN) # takes several seconds to update, so do it now.
+        subprocess.check_call(NMSCAN, timeout=1.) # takes several seconds to update, so do it now.
     except subprocess.CalledProcessError as e:
         logging.error(f'consider slowing scan cadence.  {e}')
 
@@ -101,14 +101,12 @@ def csv2kml(csvfn:Path, kmlfn:Path):
 # %% write KML
     """
     http://simplekml.readthedocs.io/en/latest/geometries.html#gxtrack
+    https://simplekml.readthedocs.io/en/latest/kml.html#id1
+    https://simplekml.readthedocs.io/en/latest/geometries.html#simplekml.GxTrack
     """
-    kml = Kml(name='My Kml',open=1)
-
-
-    doc = kml.newdocument(name='Mozilla Location Services')
-    fol = doc.newfolder(name='Tracks')
-    trk = fol.newgxtrack(name='My Track')
-    trk.newwhen(t)  # list of times
+    kml = Kml(name='My Kml')
+    trk = kml.newgxtrack(name='My Track')
+    trk.newwhen(t)  # list of times. MUST be format 2010-05-28T02:02:09Z
     trk.newgxcoord(lla.tolist()) #list of lon,lat,alt, NOT ndarray!
 
 # just a bunch of points