From 725f8b3af01712c19f05be6971a8c7570d5a545c Mon Sep 17 00:00:00 2001 From: Badr-MOUFAD Date: Tue, 29 Apr 2025 22:49:29 +0200 Subject: [PATCH 1/2] rm unnecessary init --- skglm/estimators.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/skglm/estimators.py b/skglm/estimators.py index 4d7ddd92..b7474dc6 100644 --- a/skglm/estimators.py +++ b/skglm/estimators.py @@ -102,10 +102,10 @@ def _glm_fit(X, y, model, datafit, penalty, solver): n_samples, n_features = X_.shape - if issparse(X): - datafit.initialize_sparse(X_.data, X_.indptr, X_.indices, y) - else: - datafit.initialize(X_, y) + # if issparse(X): + # datafit.initialize_sparse(X_.data, X_.indptr, X_.indices, y) + # else: + # datafit.initialize(X_, y) # if model.warm_start and hasattr(model, 'coef_') and model.coef_ is not None: if solver.warm_start and hasattr(model, 'coef_') and model.coef_ is not None: From fec81006b2e6a69c519663269e5abb95ec956791 Mon Sep 17 00:00:00 2001 From: Badr-MOUFAD Date: Wed, 30 Apr 2025 00:28:28 +0200 Subject: [PATCH 2/2] stale commit --- skglm/estimators.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/skglm/estimators.py b/skglm/estimators.py index b7474dc6..8e327d89 100644 --- a/skglm/estimators.py +++ b/skglm/estimators.py @@ -102,11 +102,6 @@ def _glm_fit(X, y, model, datafit, penalty, solver): n_samples, n_features = X_.shape - # if issparse(X): - # datafit.initialize_sparse(X_.data, X_.indptr, X_.indices, y) - # else: - # datafit.initialize(X_, y) - # if model.warm_start and hasattr(model, 'coef_') and model.coef_ is not None: if solver.warm_start and hasattr(model, 'coef_') and model.coef_ is not None: if isinstance(datafit, QuadraticSVC):