SwingObjectWidget: set values by string comparison

Previously, we were trying to set the JComboBox value
with a new instance of the object.

We don't always have the possibility to keep a list of the allowed
choices for the current model, nor can we override the `equals()` method
for the `Object`s of this widget instance.
So we have to fall back to comparing all combobox items to the current
value by their `toString()` and `ObjectService.getName()` strings.

Author: imagejan

src/main/java/org/scijava/ui/swing/widget/SwingObjectWidget.java

@@ -108,8 +108,23 @@ public boolean supports(final WidgetModel model) {
 	@Override
 	public void doRefresh() {
 		final Object value = get().getValue();
-		if (value == comboBox.getSelectedItem()) return; // no change
-		comboBox.setSelectedItem(value);
+		if (comboBox.getSelectedItem().toString().equals(nameOf(value))) return; // no change
+		updateComboBox(comboBox, value);
+	}
+
+	private void updateComboBox(final JComboBox<Object> comboBox, final Object value) {
+		for (int i = 0; i < comboBox.getModel().getSize(); i++)
+		{
+		    if (comboBox.getItemAt(i).toString().equals(nameOf(value)))
+		    {
+		    	comboBox.setSelectedIndex(i);
+		        break;
+		    }
+		}
+	}
+
+	private String nameOf(final Object value) {
+		return value == null ? "" : context().service(ObjectService.class).getName(value);
 	}
 
 	private class NamedObjectCellRenderer implements ListCellRenderer<Object> {
@@ -120,7 +135,7 @@ private class NamedObjectCellRenderer implements ListCellRenderer<Object> {
 		public Component getListCellRendererComponent(JList<?> list, Object value, int index, boolean isSelected,
 				boolean cellHasFocus) {
 			JLabel renderer = (JLabel) defaultRenderer.getListCellRendererComponent(list, value, index, isSelected, cellHasFocus);
-			renderer.setText(value == null ? "" : context().service(ObjectService.class).getName(value));
+			renderer.setText(nameOf(value));
 			renderer.setToolTipText(value == null ? null : value.toString());
 			return renderer;
 		}