Add named object index and improve ObjectService

imagejan · imagejan · commit a5d0fc09550e · 2020-01-04T22:06:27.000+01:00
diff --git a/src/main/java/org/scijava/object/DefaultObjectService.java b/src/main/java/org/scijava/object/DefaultObjectService.java
@@ -34,6 +34,7 @@
 
 import java.util.List;
 
+import org.scijava.Named;
 import org.scijava.event.EventHandler;
 import org.scijava.event.EventService;
 import org.scijava.object.event.ObjectCreatedEvent;
@@ -68,7 +69,7 @@ public final class DefaultObjectService extends AbstractService implements
 	private EventService eventService;
 
 	/** Index of registered objects. */
-	private ObjectIndex<Object> objectIndex;
+	private NamedObjectIndex<Object> objectIndex;
 
 	// -- ObjectService methods --
 
@@ -92,7 +93,12 @@ public <T> List<T> getObjects(final Class<T> type) {
 
 	@Override
 	public void addObject(final Object obj) {
-		objectIndex.add(obj);
+		addObject(obj, null);
+	}
+
+	@Override
+	public void addObject(Object obj, String name) {
+		objectIndex.add(obj, name);		
 		eventService.publish(new ObjectsAddedEvent(obj));
 	}
 
@@ -102,11 +108,23 @@ public void removeObject(final Object obj) {
 		eventService.publish(new ObjectsRemovedEvent(obj));
 	}
 
+	@Override
+	public String getName(Object obj) {
+		String name = objectIndex.getName(obj);
+		if (name != null) {
+			return name;
+		}
+		if (obj instanceof Named) {
+			return ((Named) obj).getName();
+		}
+		return obj.toString();
+	}
+
 	// -- Service methods --
 
 	@Override
 	public void initialize() {
-		objectIndex = new ObjectIndex<>(Object.class);
+		objectIndex = new NamedObjectIndex<>(Object.class);
 	}
 
 	// -- Event handlers --
@@ -120,5 +138,4 @@ protected void onEvent(final ObjectCreatedEvent event) {
 	protected void onEvent(final ObjectDeletedEvent event) {
 		removeObject(event.getObject());
 	}
-
 }
diff --git a/src/main/java/org/scijava/object/NamedObjectIndex.java b/src/main/java/org/scijava/object/NamedObjectIndex.java
@@ -0,0 +1,29 @@
+package org.scijava.object;
+
+import java.util.WeakHashMap;
+
+public class NamedObjectIndex<E> extends ObjectIndex<E> {
+	
+	private WeakHashMap<Object, String> nameMap;
+
+	public NamedObjectIndex(final Class<E> baseClass) {
+		super(baseClass);
+		nameMap = new WeakHashMap<>();
+	}
+
+	public boolean add(E object, String name) {
+		if (name != null)
+			nameMap.put(object, name);
+		return add(object);
+	}
+
+	public boolean add(E object, Class<?> type, String name, boolean batch) {
+		if (name != null)
+			nameMap.put(object, name);
+		return add(object, type, batch);
+	}
+
+	public String getName(E object) {
+		return nameMap.get(object);
+	}
+}
diff --git a/src/main/java/org/scijava/object/ObjectService.java b/src/main/java/org/scijava/object/ObjectService.java
@@ -34,6 +34,7 @@
 
 import java.util.List;
 
+import org.scijava.Named;
 import org.scijava.event.EventService;
 import org.scijava.service.SciJavaService;
 
@@ -54,9 +55,21 @@ default EventService eventService() {
 	/** Gets a list of all registered objects compatible with the given type. */
 	<T> List<T> getObjects(Class<T> type);
 
+	/**
+	 * Gets the name belonging to a given object.
+	 * 
+	 * If no explicit name was provided at registration time, the name will be
+	 * derived from {@link Named#getName()} if the object implements {@link Named},
+	 * or from the {@link Object#toString()} otherwise
+	 **/
+	String getName(Object obj);
+
 	/** Registers an object with the object service. */
 	void addObject(Object obj);
 
+	/** Registers a named object with the object service. */
+	void addObject(Object obj, String name);
+
 	/** Deregisters an object with the object service. */
 	void removeObject(Object obj);
 
diff --git a/src/main/java/org/scijava/widget/DefaultWidgetModel.java b/src/main/java/org/scijava/widget/DefaultWidgetModel.java
@@ -47,6 +47,7 @@
 import org.scijava.module.Module;
 import org.scijava.module.ModuleItem;
 import org.scijava.module.ModuleService;
+import org.scijava.object.ObjectService;
 import org.scijava.plugin.Parameter;
 import org.scijava.thread.ThreadService;
 import org.scijava.util.NumberUtils;
@@ -74,6 +75,9 @@ public class DefaultWidgetModel extends AbstractContextual implements WidgetMode
 	@Parameter
 	private ModuleService moduleService;
 
+	@Parameter
+	private ObjectService objectService;
+
 	@Parameter(required = false)
 	private LogService log;
 
@@ -227,7 +231,7 @@ public String[] getChoices() {
 		final List<?> choicesList = item.getChoices();
 		final String[] choices = new String[choicesList.size()];
 		for (int i = 0; i < choices.length; i++) {
-			choices[i] = choicesList.get(i).toString();
+			choices[i] = objectService.getName(choicesList.get(i));
 		}
 		return choices;
 	}
diff --git a/src/test/java/org/scijava/object/NamedObjectIndexTest.java b/src/test/java/org/scijava/object/NamedObjectIndexTest.java
@@ -0,0 +1,43 @@
+package org.scijava.object;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+import org.junit.Test;
+
+public class NamedObjectIndexTest {
+
+	@Test
+	public void testNamedObjects() {
+		NamedObjectIndex<String> index = new NamedObjectIndex<>(String.class);
+		String obj1 = "obj1";
+		String name1 = "name1";
+		String obj2 = "obj1";
+		String name2 = "name1";
+		assertTrue(index.add(obj1, name1));
+		assertTrue(index.add(obj2, String.class, name2, false));
+		assertTrue(index.contains(obj1));
+		assertTrue(index.contains(obj2));
+		assertEquals(name1, index.getName(obj1));
+		assertEquals(name2, index.getName(obj2));
+		assertTrue(index.remove(obj1));
+		assertTrue(index.remove(obj2));
+		assertFalse(index.contains(obj1));
+		assertFalse(index.contains(obj2));
+	}
+
+	@Test
+	public void testNullNames() {
+		NamedObjectIndex<String> index = new NamedObjectIndex<>(String.class);
+		String obj1 = "object1";
+		String name1 = null;
+		String obj2 = "object2";
+		String name2 = "";
+		assertTrue(index.add(obj1, name1));
+		assertTrue(index.add(obj2, name2));
+		assertEquals(name1, index.getName(obj1));
+		assertEquals(name2, index.getName(obj2));
+	}
+}
diff --git a/src/test/java/org/scijava/object/ObjectServiceTest.java b/src/test/java/org/scijava/object/ObjectServiceTest.java
@@ -0,0 +1,75 @@
+package org.scijava.object;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.scijava.Context;
+import org.scijava.plugin.PluginInfo;
+import org.scijava.plugin.SciJavaPlugin;
+
+public class ObjectServiceTest {
+
+	private Context context;
+	private ObjectService objectService;
+
+	@Before
+	public void setUp() {
+		context = new Context(ObjectService.class);
+		objectService = context.getService(ObjectService.class);
+	}
+
+	@After
+	public void tearDown() {
+		context.dispose();
+	}
+
+	@Test
+	public void testAddRemoveObjects() {
+		Object obj1 = new Object();
+		String name1 = "Object 1";
+		Object obj2 = "";
+		Object obj3 = new Double(0.3);
+		PluginInfo<SciJavaPlugin> obj4 = PluginInfo.create(TestPlugin.class, SciJavaPlugin.class);
+		obj4.setName("TestPlugin name");
+
+		objectService.addObject(obj1, name1);
+		assertEquals("Name of object 1", name1, objectService.getName(obj1));
+		objectService.addObject(obj2);
+		assertEquals("Name of object 2", obj2.toString(), objectService.getName(obj2));
+		objectService.addObject(obj3, null);
+		assertEquals("Name of object 3", obj3.toString(), objectService.getName(obj3));
+		objectService.addObject(obj4);
+		assertNotNull(objectService.getName(obj4));
+		assertEquals("Name of object 4", obj4.getName(), objectService.getName(obj4));
+
+		assertTrue("Object 1 registered", objectService.getObjects(Object.class).contains(obj1));
+		assertTrue("Object 2 registered", objectService.getObjects(Object.class).contains(obj2));
+		assertTrue("Object 3 registered", objectService.getObjects(Object.class).contains(obj3));
+		assertTrue("Object 4 registered", objectService.getObjects(Object.class).contains(obj4));
+
+		objectService.removeObject(obj1);
+		objectService.removeObject(obj2);
+		objectService.removeObject(obj3);
+		objectService.removeObject(obj4);
+
+		assertFalse("Object 1 removed", objectService.getObjects(Object.class).contains(obj1));
+		assertFalse("Object 2 removed", objectService.getObjects(Object.class).contains(obj2));
+		assertFalse("Object 3 removed", objectService.getObjects(Object.class).contains(obj3));
+		assertFalse("Object 4 removed", objectService.getObjects(Object.class).contains(obj4));
+	}
+
+	@Test
+	public void testNamedObjectIndex() {
+		ObjectIndex<Object> index = objectService.getIndex();
+		assertTrue(index instanceof NamedObjectIndex);
+	}
+
+	private class TestPlugin implements SciJavaPlugin {
+
+	}
+}
