ScriptService: fix bug in getOrCreate

ctrueden · ctrueden · commit 8b1256257f7e · 2018-07-24T23:02:19.000-05:00
Without this change, the cache missed every time, due to the wrong
key (a File rather than a String path) being used for the lookup.

Thanks Eclipse for the warning.
diff --git a/src/main/java/org/scijava/script/DefaultScriptService.java b/src/main/java/org/scijava/script/DefaultScriptService.java
@@ -353,7 +353,7 @@ private synchronized void initAliasMap() {
 	 * are registered with the service.
 	 */
 	private ScriptInfo getOrCreate(final File file) {
-		final ScriptInfo info = scripts().get(file);
+		final ScriptInfo info = scripts().get(file.getAbsolutePath());
 		if (info != null) return info;
 		return new ScriptInfo(getContext(), file);
 	}

Original file line number	Diff line number	Diff line change
`@@ -353,7 +353,7 @@ private synchronized void initAliasMap() {`
`353`	`353`	`* are registered with the service.`
`354`	`354`	`*/`
`355`	`355`	`private ScriptInfo getOrCreate(final File file) {`
`356`		`- final ScriptInfo info = scripts().get(file);`
	`356`	`+ final ScriptInfo info = scripts().get(file.getAbsolutePath());`
`357`	`357`	`if (info != null) return info;`
`358`	`358`	`return new ScriptInfo(getContext(), file);`
`359`	`359`	`}`