Fix integer overflow in hash function. (#454)

Augustin-Zidek · web-flow · commit 448e1dcf15c4 · 2025-05-07T07:54:19.000-04:00
diff --git a/ov/src/OVLexicon.cpp b/ov/src/OVLexicon.cpp
@@ -99,7 +99,7 @@ static OVstatus OVLexicon_CheckStorage(OVLexicon * uk, ov_word entry_size,
 static ov_word _GetCStringHash(ov_uchar8 * str)
 {
   const ov_uchar8 *p = str;
-  ov_word x;
+  ov_size x;
   ov_size len = 0;
   ov_uchar8 c;
 
@@ -109,7 +109,7 @@ static ov_word _GetCStringHash(ov_uchar8 * str)
     len++;
   }
   x ^= len;
-  return x;
+  return static_cast<ov_word>(x);
 }
 
 OVstatus OVLexicon_Pack(OVLexicon * uk)

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ static OVstatus OVLexicon_CheckStorage(OVLexicon * uk, ov_word entry_size,`
`99`	`99`	`static ov_word _GetCStringHash(ov_uchar8 * str)`
`100`	`100`	`{`
`101`	`101`	`const ov_uchar8 *p = str;`
`102`		`- ov_word x;`
	`102`	`+ ov_size x;`
`103`	`103`	`ov_size len = 0;`
`104`	`104`	`ov_uchar8 c;`
`105`	`105`
`@@ -109,7 +109,7 @@ static ov_word _GetCStringHash(ov_uchar8 * str)`
`109`	`109`	`len++;`
`110`	`110`	`}`
`111`	`111`	`x ^= len;`
`112`		`- return x;`
	`112`	`+ return static_cast<ov_word>(x);`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`OVstatus OVLexicon_Pack(OVLexicon * uk)`