Skip to content

ToBytes, return []byte{0,0,0,0} when string is empty #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ToBytes, return []byte{0,0,0,0} when string is empty #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions osc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ type Packet interface {
// This means that the returned byte slice is padded with null bytes
// so that it's length is a multiple of 4.
func ToBytes(s string) []byte {
if len(s) == 0 {
return []byte{}
if s == "" {
return []byte{0, 0, 0, 0}
}
return Pad(append([]byte(s), 0))
}
Expand Down
2 changes: 1 addition & 1 deletion osc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ func TestToBytes(t *testing.T) {
}{
{
Input: "",
Expected: []byte{},
Expected: []byte{0, 0, 0, 0},
},
{
Input: "a",
Expand Down