Remove SERIALIZATION_SPLIT_MEMBER

SERIALIZATION_SPLIT_MEMBER generates a
`template<typename Archive> sample::serialize(Archive, uint)` function that
tries to detect the type of archive it is called with and then calls either
`save()` or `load()`. As the `Archive` is either `eos::portable_iarchive` *or*
`eos::portable_oarchive`, we can just define `serialize()` as overloaded
function and avoid the overhead altogether.

Author: tstenner

src/sample.cpp

@@ -280,7 +280,7 @@ template <class Archive> void sample::serialize_channels(Archive &ar, const uint
 	}
 }
 
-void sample::save(eos::portable_oarchive &ar, const uint32_t archive_version) const {
+void lsl::sample::serialize(eos::portable_oarchive &ar, const uint32_t archive_version) const {
 	// write sample header
 	if (timestamp == DEDUCED_TIMESTAMP) {
 		ar &TAG_DEDUCED_TIMESTAMP;
@@ -291,7 +291,7 @@ void sample::save(eos::portable_oarchive &ar, const uint32_t archive_version) co
 	const_cast<sample *>(this)->serialize_channels(ar, archive_version);
 }
 
-void sample::load(eos::portable_iarchive &ar, const uint32_t archive_version) {
+void lsl::sample::serialize(eos::portable_iarchive &ar, const uint32_t archive_version) {
 	// read sample header
 	char tag;
 	ar &tag;

src/sample.h

@@ -5,7 +5,6 @@
 #include "util/cast.hpp"
 #include <atomic>
 #include <boost/endian/conversion.hpp>
-#include <boost/serialization/split_member.hpp>
 #include <cstdint>
 #include <iosfwd>
 #include <limits>
@@ -304,17 +303,16 @@ class sample {
 		default: throw std::runtime_error("Unsupported channel format for endian conversion.");
 		}
 	}
+
 	/// Serialize a sample into a portable archive (protocol 1.00).
-	void save(eos::portable_oarchive &ar, const uint32_t archive_version) const;
+	void serialize(eos::portable_oarchive &ar, const uint32_t archive_version) const;
 
 	/// Deserialize a sample from a portable archive (protocol 1.00).
-	void load(eos::portable_iarchive &ar, const uint32_t archive_version);
+	void serialize(eos::portable_iarchive &ar, const uint32_t archive_version);
 
 	/// Serialize (read/write) the channel data.
 	template <class Archive> void serialize_channels(Archive &ar, const uint32_t archive_version);
 
-	BOOST_SERIALIZATION_SPLIT_MEMBER()
-
 	/// Assign a test pattern to the sample (for protocol validation)
 	sample &assign_test_pattern(int offset = 1);