Use pthread_setname_np; set names in the debugger view

Author: tstenner

testing/int/loguruthreadnames.cpp

@@ -6,13 +6,13 @@
 // clazy:excludeall=non-pod-global-static
 
 TEST_CASE("loguru_thread_local_storage", "[threading]") {
-	char name[2] = "0";
+	char name[16] = "0";
 	loguru::set_thread_name("1");
-	std::thread([&](){
+	std::thread([&]() {
 		loguru::set_thread_name("2");
-		loguru::get_thread_name(name,2,false);
+		loguru::get_thread_name(name, sizeof(name), false);
 	}).join();
 	REQUIRE(name[0] == '2');
-	loguru::get_thread_name(name,2,false);
+	loguru::get_thread_name(name, sizeof(name), false);
 	REQUIRE(name[0] == '1');
 }

thirdparty/loguru/loguru.cpp

@@ -109,16 +109,6 @@
 	#elif defined(__OpenBSD__)
 		#include <pthread_np.h>
 	#endif
-
-	#ifdef __linux__
-		/* On Linux, the default thread name is the same as the name of the binary.
-		   Additionally, all new threads inherit the name of the thread it got forked from.
-		   For this reason, Loguru use the pthread Thread Local Storage
-		   for storing thread names on Linux. */
-		#ifndef LOGURU_PTLS_NAMES
-			#define LOGURU_PTLS_NAMES 1
-		#endif
-	#endif
 #endif
 
 #if LOGURU_WINTHREADS
@@ -1066,7 +1056,8 @@ namespace loguru
 			// Ask the OS about the thread name.
 			// This is what we *want* to do on all platforms, but
 			// only some platforms support it (currently).
-			pthread_getname_np(pthread_self(), buffer, length);
+			if(pthread_getname_np(pthread_self(), buffer, length) != 0)
+				buffer[0] = 0;
 		#elif LOGURU_WINTHREADS
 			snprintf(buffer, static_cast<size_t>(length), "%s", thread_name_buffer());
 		#else