CMake: clean up target include directories

tstenner · tstenner · commit 65ccfcafcc09 · 2021-09-23T09:05:00.000+02:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -183,10 +183,15 @@ target_include_directories(lslboost SYSTEM PUBLIC
 # target configuration for the internal lslobj target
 target_link_libraries(lslobj PRIVATE lslboost)
 target_include_directories(lslobj
-	PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/include>
+	PUBLIC
+		$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/include>
+		$<INSTALL_INTERFACE:include>
+	INTERFACE # for unit tests
+		$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/src>
 	)
-target_include_directories(lslobj SYSTEM PUBLIC
-	$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/thirdparty/loguru>
+target_include_directories(lslobj
+	SYSTEM PUBLIC
+		$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/thirdparty/loguru>
 )
 target_compile_definitions(lslobj PRIVATE
 	LIBLSL_EXPORTS
diff --git a/testing/CMakeLists.txt b/testing/CMakeLists.txt
@@ -42,7 +42,6 @@ add_executable(lsl_test_internal
 	internal/serialization_v100.cpp
 )
 target_link_libraries(lsl_test_internal PRIVATE lslobj lslboost catch_main)
-target_include_directories(lsl_test_internal PRIVATE ${CMAKE_CURRENT_LIST_DIR}/../src/)
 
 if(LSL_BENCHMARKS)
 	# to get somewhat reproducible performance numbers:

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,6 @@ add_executable(lsl_test_internal`
`42`	`42`	`internal/serialization_v100.cpp`
`43`	`43`	`)`
`44`	`44`	`target_link_libraries(lsl_test_internal PRIVATE lslobj lslboost catch_main)`
`45`		`-target_include_directories(lsl_test_internal PRIVATE ${CMAKE_CURRENT_LIST_DIR}/../src/)`
`46`	`45`
`47`	`46`	`if(LSL_BENCHMARKS)`
`48`	`47`	`# to get somewhat reproducible performance numbers:`