Fix a few clang-analyzer warnings

Author: tstenner

src/netinterfaces.cpp

@@ -2,8 +2,6 @@
 #include <cstring>
 #include <loguru.hpp>
 
-using asio::ip::address_v4;
-
 asio::ip::address_v6 sinaddr_to_asio(sockaddr_in6 *addr) {
 	asio::ip::address_v6::bytes_type buf;
 	memcpy(buf.data(), addr->sin6_addr.s6_addr, sizeof(addr->sin6_addr));

src/tcp_server.cpp

@@ -336,7 +336,7 @@ void client_session::handle_read_query_outcome(err_t err) {
 		if (serv_->info_->matches_query(query)) {
 			// matches: reply (otherwise just close the stream)
 			async_write(*sock_, asio::buffer(serv_->shortinfo_msg_),
-				[shared_this = shared_from_this() /*unused*/](err_t, std::size_t /*unused*/) {
+				[shared_this = shared_from_this()](err_t /*unused*/, std::size_t /*unused*/) {
 					/* keep the client_session alive until the shortinfo is sent completely*/
 				});
 		} else {
@@ -347,10 +347,10 @@ void client_session::handle_read_query_outcome(err_t err) {
 	}
 }
 
-void client_session::send_status_message(const std::string &str) {
-	auto msg(std::make_shared<std::string>(str));
-	async_write(*sock_, asio::buffer(*msg),
-		[msg, shared_this = shared_from_this()](err_t /*unused*/,
+void client_session::send_status_message(const std::string &msg) {
+	auto buf(std::make_shared<std::string>(msg));
+	async_write(*sock_, asio::buffer(*buf),
+		[buf, shared_this = shared_from_this()](err_t /*unused*/,
 			std::size_t /*unused*/) { /* keep objects alive until the message is sent */ });
 }
 
@@ -478,7 +478,7 @@ void client_session::handle_read_feedparams(
 		// --- validation ---
 		if (data_protocol_version_ == 100) {
 			// create a portable output archive to write to
-			outarch_.reset(new eos::portable_oarchive(feedbuf_));
+			outarch_ = std::make_unique<eos::portable_oarchive>(feedbuf_);
 			// serialize the shortinfo message into an archive
 			*outarch_ << serv_->shortinfo_msg_;
 		} else {

src/udp_server.cpp

@@ -89,10 +89,10 @@ void udp_server::end_serving() {
 	// gracefully close the socket; this will eventually lead to the cancellation of the IO
 	// operation(s) tied to its socket
 	auto sock(socket_); // socket shared ptr to be kept alive
-	post(io_, [sock]() {
+	post(io_, [sock, fn = __func__]() {
 		try {
 			if (sock->is_open()) sock->close();
-		} catch (std::exception &e) { LOG_F(ERROR, "Error during %s: %s", __func__, e.what()); }
+		} catch (std::exception &e) { LOG_F(ERROR, "Error during %s: %s", fn, e.what()); }
 	});
 }
 
@@ -125,7 +125,7 @@ void udp_server::process_shortinfo_request(std::istream& request_stream)
 		string_p replymsg(
 			std::make_shared<std::string>((query_id += "\r\n") += shortinfo_msg_));
 		socket_->async_send_to(asio::buffer(*replymsg), return_endpoint,
-			[shared_this = shared_from_this(), replymsg](err_t err_, std::size_t) {
+			[shared_this = shared_from_this(), replymsg](err_t err_, std::size_t /*unused*/) {
 				if (err_ != asio::error::operation_aborted && err_ != asio::error::shut_down)
 					shared_this->request_next_packet();
 			});
@@ -147,7 +147,7 @@ void udp_server::process_timedata_request(std::istream &request_stream, double t
 	reply << ' ' << wave_id << ' ' << t0 << ' ' << t1 << ' ' << lsl_clock();
 	string_p replymsg(std::make_shared<std::string>(reply.str()));
 	socket_->async_send_to(asio::buffer(*replymsg), remote_endpoint_,
-		[shared_this = shared_from_this(), replymsg](err_t err_, std::size_t) {
+		[shared_this = shared_from_this(), replymsg](err_t err_, std::size_t /*unused*/) {
 			if (err_ != asio::error::operation_aborted && err_ != asio::error::shut_down)
 				shared_this->request_next_packet();
 		});