Skip to content

Commit 8412ee4

Browse files
authored
fix(DOM): better arguments for CheckContactsCompatibility (#41)
1 parent ab8a4dc commit 8412ee4

File tree

6 files changed

+20
-40
lines changed

6 files changed

+20
-40
lines changed

scaleway-async/scaleway_async/domain/v2beta1/api.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1657,8 +1657,8 @@ async def delete_external_domain(
16571657
async def check_contacts_compatibility(
16581658
self,
16591659
*,
1660-
domain: Optional[str] = None,
1661-
tld: Optional[str] = None,
1660+
domains: Optional[List[str]] = None,
1661+
tlds: Optional[List[str]] = None,
16621662
owner_contact_id: Optional[str] = None,
16631663
owner_contact: Optional[NewContact] = None,
16641664
administrative_contact_id: Optional[str] = None,
@@ -1670,8 +1670,8 @@ async def check_contacts_compatibility(
16701670
Check if contacts are compatible against a domain or a tld.
16711671
If not, it will return the information requiring a correction.
16721672
1673-
:param domain: One-of ('parameter'): at most one of 'domain', 'tld' could be set.
1674-
:param tld: One-of ('parameter'): at most one of 'domain', 'tld' could be set.
1673+
:param domains:
1674+
:param tlds:
16751675
:param owner_contact_id: One-of ('owner_contact_type'): at most one of 'owner_contact_id', 'owner_contact' could be set.
16761676
:param owner_contact: One-of ('owner_contact_type'): at most one of 'owner_contact_id', 'owner_contact' could be set.
16771677
:param administrative_contact_id: One-of ('administrative_contact_type'): at most one of 'administrative_contact_id', 'administrative_contact' could be set.
@@ -1691,8 +1691,8 @@ async def check_contacts_compatibility(
16911691
f"/domain/v2beta1/check-contacts-compatibility",
16921692
body=marshal_RegistrarApiCheckContactsCompatibilityRequest(
16931693
RegistrarApiCheckContactsCompatibilityRequest(
1694-
domain=domain,
1695-
tld=tld,
1694+
domains=domains,
1695+
tlds=tlds,
16961696
owner_contact_id=owner_contact_id,
16971697
owner_contact=owner_contact,
16981698
administrative_contact_id=administrative_contact_id,

scaleway-async/scaleway_async/domain/v2beta1/marshalling.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2287,18 +2287,14 @@ def marshal_RegistrarApiCheckContactsCompatibilityRequest(
22872287
OneOfPossibility("owner_contact", request.owner_contact),
22882288
]
22892289
),
2290-
**resolve_one_of(
2291-
[
2292-
OneOfPossibility("domain", request.domain),
2293-
OneOfPossibility("tld", request.tld),
2294-
]
2295-
),
22962290
**resolve_one_of(
22972291
[
22982292
OneOfPossibility("technical_contact_id", request.technical_contact_id),
22992293
OneOfPossibility("technical_contact", request.technical_contact),
23002294
]
23012295
),
2296+
"domains": request.domains,
2297+
"tlds": request.tlds,
23022298
}
23032299

23042300

scaleway-async/scaleway_async/domain/v2beta1/types.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1846,15 +1846,9 @@ class RegistrarApiDeleteExternalDomainRequest:
18461846

18471847
@dataclass
18481848
class RegistrarApiCheckContactsCompatibilityRequest:
1849-
domain: Optional[str]
1850-
"""
1851-
One-of ('parameter'): at most one of 'domain', 'tld' could be set.
1852-
"""
1849+
domains: Optional[List[str]]
18531850

1854-
tld: Optional[str]
1855-
"""
1856-
One-of ('parameter'): at most one of 'domain', 'tld' could be set.
1857-
"""
1851+
tlds: Optional[List[str]]
18581852

18591853
owner_contact_id: Optional[str]
18601854
"""

scaleway/scaleway/domain/v2beta1/api.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1655,8 +1655,8 @@ def delete_external_domain(
16551655
def check_contacts_compatibility(
16561656
self,
16571657
*,
1658-
domain: Optional[str] = None,
1659-
tld: Optional[str] = None,
1658+
domains: Optional[List[str]] = None,
1659+
tlds: Optional[List[str]] = None,
16601660
owner_contact_id: Optional[str] = None,
16611661
owner_contact: Optional[NewContact] = None,
16621662
administrative_contact_id: Optional[str] = None,
@@ -1668,8 +1668,8 @@ def check_contacts_compatibility(
16681668
Check if contacts are compatible against a domain or a tld.
16691669
If not, it will return the information requiring a correction.
16701670
1671-
:param domain: One-of ('parameter'): at most one of 'domain', 'tld' could be set.
1672-
:param tld: One-of ('parameter'): at most one of 'domain', 'tld' could be set.
1671+
:param domains:
1672+
:param tlds:
16731673
:param owner_contact_id: One-of ('owner_contact_type'): at most one of 'owner_contact_id', 'owner_contact' could be set.
16741674
:param owner_contact: One-of ('owner_contact_type'): at most one of 'owner_contact_id', 'owner_contact' could be set.
16751675
:param administrative_contact_id: One-of ('administrative_contact_type'): at most one of 'administrative_contact_id', 'administrative_contact' could be set.
@@ -1689,8 +1689,8 @@ def check_contacts_compatibility(
16891689
f"/domain/v2beta1/check-contacts-compatibility",
16901690
body=marshal_RegistrarApiCheckContactsCompatibilityRequest(
16911691
RegistrarApiCheckContactsCompatibilityRequest(
1692-
domain=domain,
1693-
tld=tld,
1692+
domains=domains,
1693+
tlds=tlds,
16941694
owner_contact_id=owner_contact_id,
16951695
owner_contact=owner_contact,
16961696
administrative_contact_id=administrative_contact_id,

scaleway/scaleway/domain/v2beta1/marshalling.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2287,18 +2287,14 @@ def marshal_RegistrarApiCheckContactsCompatibilityRequest(
22872287
OneOfPossibility("owner_contact", request.owner_contact),
22882288
]
22892289
),
2290-
**resolve_one_of(
2291-
[
2292-
OneOfPossibility("domain", request.domain),
2293-
OneOfPossibility("tld", request.tld),
2294-
]
2295-
),
22962290
**resolve_one_of(
22972291
[
22982292
OneOfPossibility("technical_contact_id", request.technical_contact_id),
22992293
OneOfPossibility("technical_contact", request.technical_contact),
23002294
]
23012295
),
2296+
"domains": request.domains,
2297+
"tlds": request.tlds,
23022298
}
23032299

23042300

scaleway/scaleway/domain/v2beta1/types.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1846,15 +1846,9 @@ class RegistrarApiDeleteExternalDomainRequest:
18461846

18471847
@dataclass
18481848
class RegistrarApiCheckContactsCompatibilityRequest:
1849-
domain: Optional[str]
1850-
"""
1851-
One-of ('parameter'): at most one of 'domain', 'tld' could be set.
1852-
"""
1849+
domains: Optional[List[str]]
18531850

1854-
tld: Optional[str]
1855-
"""
1856-
One-of ('parameter'): at most one of 'domain', 'tld' could be set.
1857-
"""
1851+
tlds: Optional[List[str]]
18581852

18591853
owner_contact_id: Optional[str]
18601854
"""

0 commit comments

Comments
 (0)