fix(instance): resolve image label according to boot volume type (#2626)

Author: Mia-Cross

api/instance/v1/server_utils.go

@@ -24,11 +24,18 @@ func (s *API) CreateServer(req *CreateServerRequest, opts ...scw.RequestOption)
 	// If image is not a UUID we try to fetch it from marketplace.
 	if req.Image != nil && !validation.IsUUID(*req.Image) {
 		apiMarketplace := marketplace.NewAPI(s.client)
-		image, err := apiMarketplace.GetLocalImageByLabel(&marketplace.GetLocalImageByLabelRequest{
+
+		getLocalImageByLabelRequest := &marketplace.GetLocalImageByLabelRequest{
 			ImageLabel:     *req.Image,
 			Zone:           req.Zone,
 			CommercialType: req.CommercialType,
-		})
+		}
+
+		if bootVolumeType := getBootVolumeType(req.Volumes); bootVolumeType != nil {
+			getLocalImageByLabelRequest.Type = *bootVolumeType
+		}
+
+		image, err := apiMarketplace.GetLocalImageByLabel(getLocalImageByLabelRequest)
 		if err != nil {
 			return nil, err
 		}
@@ -38,6 +45,36 @@ func (s *API) CreateServer(req *CreateServerRequest, opts ...scw.RequestOption)
 	return s.createServer(req, opts...)
 }
 
+func getBootVolumeType(volumes map[string]*VolumeServerTemplate) *marketplace.LocalImageType {
+	var bootVolumeType marketplace.LocalImageType
+	foundBootVolume := false
+
+	for _, volume := range volumes {
+		if volume.Boot == nil {
+			continue
+		}
+		if *volume.Boot {
+			foundBootVolume = true
+			switch volume.VolumeType {
+			case VolumeVolumeTypeSbsVolume:
+				bootVolumeType = marketplace.LocalImageTypeInstanceSbs
+			case VolumeVolumeTypeLSSD:
+				bootVolumeType = marketplace.LocalImageTypeInstanceLocal
+			}
+		}
+	}
+
+	if !foundBootVolume && len(volumes) > 0 {
+		switch volumes["0"].VolumeType {
+		case VolumeVolumeTypeSbsVolume:
+			bootVolumeType = marketplace.LocalImageTypeInstanceSbs
+		case VolumeVolumeTypeLSSD:
+			bootVolumeType = marketplace.LocalImageTypeInstanceLocal
+		}
+	}
+	return &bootVolumeType
+}
+
 // UpdateServer updates a server.
 //
 // Note: Implementation is thread-safe.