Skip to content

Commit 38fdc5a

Browse files
authored
Refactor JdbcAdmin (#3121)
1 parent ad27355 commit 38fdc5a

File tree

7 files changed

+893
-742
lines changed

7 files changed

+893
-742
lines changed

core/src/integration-test/java/com/scalar/db/storage/jdbc/JdbcAdminTestUtils.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,25 +30,26 @@ public JdbcAdminTestUtils(Properties properties) {
3030
@Override
3131
public void dropNamespacesTable() throws Exception {
3232
execute(
33-
"DROP TABLE " + rdbEngine.encloseFullTableName(metadataSchema, JdbcAdmin.NAMESPACES_TABLE));
33+
"DROP TABLE "
34+
+ rdbEngine.encloseFullTableName(metadataSchema, NamespaceMetadataService.TABLE_NAME));
3435
}
3536

3637
@Override
3738
public void dropMetadataTable() throws Exception {
38-
dropTable(metadataSchema, JdbcAdmin.METADATA_TABLE);
39+
dropTable(metadataSchema, TableMetadataService.TABLE_NAME);
3940
}
4041

4142
@Override
4243
public void truncateNamespacesTable() throws Exception {
4344
String truncateTableStatement =
44-
rdbEngine.truncateTableSql(metadataSchema, JdbcAdmin.NAMESPACES_TABLE);
45+
rdbEngine.truncateTableSql(metadataSchema, NamespaceMetadataService.TABLE_NAME);
4546
execute(truncateTableStatement);
4647
}
4748

4849
@Override
4950
public void truncateMetadataTable() throws Exception {
5051
String truncateTableStatement =
51-
rdbEngine.truncateTableSql(metadataSchema, JdbcAdmin.METADATA_TABLE);
52+
rdbEngine.truncateTableSql(metadataSchema, TableMetadataService.TABLE_NAME);
5253
execute(truncateTableStatement);
5354
}
5455

@@ -57,7 +58,7 @@ public void truncateMetadataTable() throws Exception {
5758
public void corruptMetadata(String namespace, String table) throws Exception {
5859
String insertCorruptedMetadataStatement =
5960
"INSERT INTO "
60-
+ rdbEngine.encloseFullTableName(metadataSchema, JdbcAdmin.METADATA_TABLE)
61+
+ rdbEngine.encloseFullTableName(metadataSchema, TableMetadataService.TABLE_NAME)
6162
+ " VALUES ('"
6263
+ getFullTableName(namespace, table)
6364
+ "','corrupted','corrupted','corrupted','corrupted','0','0')";
@@ -68,9 +69,9 @@ public void corruptMetadata(String namespace, String table) throws Exception {
6869
public void deleteMetadata(String namespace, String table) throws Exception {
6970
String deleteMetadataStatement =
7071
"DELETE FROM "
71-
+ rdbEngine.encloseFullTableName(metadataSchema, JdbcAdmin.METADATA_TABLE)
72+
+ rdbEngine.encloseFullTableName(metadataSchema, TableMetadataService.TABLE_NAME)
7273
+ " WHERE "
73-
+ rdbEngine.enclose(JdbcAdmin.METADATA_COL_FULL_TABLE_NAME)
74+
+ rdbEngine.enclose(TableMetadataService.COL_FULL_TABLE_NAME)
7475
+ " = ?";
7576
try (Connection connection = dataSource.getConnection();
7677
PreparedStatement preparedStatement =

core/src/integration-test/java/com/scalar/db/storage/multistorage/MultiStorageAdminTestUtils.java

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,13 @@
99
import com.scalar.db.storage.cassandra.CassandraAdmin;
1010
import com.scalar.db.storage.cassandra.CassandraConfig;
1111
import com.scalar.db.storage.cassandra.ClusterManager;
12-
import com.scalar.db.storage.jdbc.JdbcAdmin;
1312
import com.scalar.db.storage.jdbc.JdbcConfig;
1413
import com.scalar.db.storage.jdbc.JdbcTestUtils;
1514
import com.scalar.db.storage.jdbc.JdbcUtils;
15+
import com.scalar.db.storage.jdbc.NamespaceMetadataService;
1616
import com.scalar.db.storage.jdbc.RdbEngineFactory;
1717
import com.scalar.db.storage.jdbc.RdbEngineStrategy;
18+
import com.scalar.db.storage.jdbc.TableMetadataService;
1819
import com.scalar.db.util.AdminTestUtils;
1920
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
2021
import java.sql.Connection;
@@ -61,7 +62,8 @@ public void dropNamespacesTable() throws SQLException {
6162
// for JDBC
6263
execute(
6364
"DROP TABLE "
64-
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, JdbcAdmin.NAMESPACES_TABLE));
65+
+ rdbEngine.encloseFullTableName(
66+
jdbcMetadataSchema, NamespaceMetadataService.TABLE_NAME));
6567
}
6668

6769
@Override
@@ -71,7 +73,7 @@ public void dropMetadataTable() throws SQLException {
7173
// for JDBC
7274
execute(
7375
"DROP TABLE "
74-
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, JdbcAdmin.METADATA_TABLE));
76+
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, TableMetadataService.TABLE_NAME));
7577
}
7678

7779
@Override
@@ -86,7 +88,7 @@ public void truncateNamespacesTable() throws SQLException {
8688

8789
// for JDBC
8890
String truncateTableStatement =
89-
rdbEngine.truncateTableSql(jdbcMetadataSchema, JdbcAdmin.NAMESPACES_TABLE);
91+
rdbEngine.truncateTableSql(jdbcMetadataSchema, NamespaceMetadataService.TABLE_NAME);
9092
execute(truncateTableStatement);
9193
}
9294

@@ -97,7 +99,7 @@ public void truncateMetadataTable() throws Exception {
9799
// for JDBC
98100
String truncateTableStatement =
99101
"TRUNCATE TABLE "
100-
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, JdbcAdmin.METADATA_TABLE);
102+
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, TableMetadataService.TABLE_NAME);
101103
execute(truncateTableStatement);
102104
}
103105

@@ -109,7 +111,7 @@ public void corruptMetadata(String namespace, String table) throws Exception {
109111
// for JDBC
110112
String insertCorruptedMetadataStatement =
111113
"INSERT INTO "
112-
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, JdbcAdmin.METADATA_TABLE)
114+
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, TableMetadataService.TABLE_NAME)
113115
+ " VALUES ('"
114116
+ getFullTableName(namespace, table)
115117
+ "','corrupted','corrupted','corrupted','corrupted','0','0')";
@@ -123,9 +125,9 @@ public void deleteMetadata(String namespace, String table) throws Exception {
123125
// for JDBC
124126
String deleteMetadataStatement =
125127
"DELETE FROM "
126-
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, JdbcAdmin.METADATA_TABLE)
128+
+ rdbEngine.encloseFullTableName(jdbcMetadataSchema, TableMetadataService.TABLE_NAME)
127129
+ " WHERE "
128-
+ rdbEngine.enclose(JdbcAdmin.METADATA_COL_FULL_TABLE_NAME)
130+
+ rdbEngine.enclose(TableMetadataService.COL_FULL_TABLE_NAME)
129131
+ " = ?";
130132
try (Connection connection = dataSource.getConnection();
131133
PreparedStatement preparedStatement =

0 commit comments

Comments
 (0)