Move unseal to avoid given import for extension method

Author: nicolasstucki

community-build/community-projects/scalatest

@@ -42,7 +42,7 @@ from the signature. The body of the `derived` method is shown below:
 
 ```scala
 given derived[T: Type](using qctx: QuoteContext) as Expr[Eq[T]] = {
-  import qctx.tasty.{_, given _}
+  import qctx.tasty._
 
   val ev: Expr[Mirror.Of[T]] = summonExpr(using '[Mirror.Of[T]]).get
 
@@ -176,7 +176,7 @@ object Eq {
   }
 
   given derived[T: Type](using qctx: QuoteContext) as Expr[Eq[T]] = {
-    import qctx.tasty.{_, given _}
+    import qctx.tasty._
 
     val ev: Expr[Mirror.Of[T]] = summonExpr(using '[Mirror.Of[T]]).get
 

docs/docs/reference/contextual/derivation-macro.md

@@ -29,22 +29,19 @@ import scala.quoted._
 inline def natConst(x: => Int): Int = ${natConstImpl('{x})}
 
 def natConstImpl(x: Expr[Int])(using qctx: QuoteContext): Expr[Int] = {
-  import qctx.tasty.{_, given _}
+  import qctx.tasty._
   ...
 }
 ```
 
-### Sealing and Unsealing
+### Extractors
 
-`import qctx.tasty.{_, given _}` will provide an `unseal` extension method on `quoted.Expr`
-and `quoted.Type` which returns a `qctx.tasty.Term` that represents the tree of
-the expression and `qctx.tasty.TypeTree` that represents the tree of the type
-respectively. It will also import all extractors and methods on TASTy Reflect
+`import qctx.tasty._` will provide all extractors and methods on TASTy Reflect
 trees. For example the `Literal(_)` extractor used below.
 
 ```scala
 def natConstImpl(x: Expr[Int])(using qctx: QuoteContext): Expr[Int] = {
-  import qctx.tasty.{_, given _}
+  import qctx.tasty._
   val xTree: Term = x.unseal
   xTree match {
     case Inlined(_, _, Literal(Constant(n: Int))) =>
@@ -81,7 +78,7 @@ operation expression passed while calling the `macro` below.
 inline def macro(param: => Boolean): Unit = ${ macroImpl('param) }
 
 def macroImpl(param: Expr[Boolean])(using qctx: QuoteContext): Expr[Unit] = {
-  import qctx.tasty.{_, given _}
+  import qctx.tasty._
   import util._
 
   param.unseal.underlyingArgument match {
@@ -103,7 +100,7 @@ point.
 
 ```scala
 def macroImpl()(qctx: QuoteContext): Expr[Unit] = {
-  import qctx.tasty.{_, given _}
+  import qctx.tasty._
   val pos = rootPosition
 
   val path = pos.sourceFile.jpath.toString

docs/docs/reference/metaprogramming/tasty-reflect.md

@@ -37,6 +37,14 @@ class Expr[+T] private[scala] {
   final def matches(that: Expr[Any])(using qctx: QuoteContext): Boolean =
     !scala.internal.quoted.Expr.unapply[Unit, Unit](this)(using that, false, qctx).isEmpty
 
+  /** Checked cast to a `quoted.Expr[U]` */
+  def cast[U](using tp: scala.quoted.Type[U])(using qctx: QuoteContext): scala.quoted.Expr[U] =
+    qctx.tasty.internal.QuotedExpr_cast[U](this)(using tp, qctx.tasty.rootContext)
+
+  /** View this expression `quoted.Expr[T]` as a `Term` */
+  def unseal(using qctx: QuoteContext): qctx.tasty.Term =
+    qctx.tasty.internal.QuotedExpr_unseal(this)(using qctx.tasty.rootContext)
+
 }
 
 object Expr {
@@ -108,7 +116,7 @@ object Expr {
    */
   def ofSeq[T](xs: Seq[Expr[T]])(using tp: Type[T], qctx: QuoteContext): Expr[Seq[T]] = {
     import qctx.tasty.{_, given _}
-    Repeated(xs.map(_.unseal).toList, tp.unseal).seal.asInstanceOf[Expr[Seq[T]]]
+    Repeated(xs.map[Term](_.unseal).toList, tp.unseal).seal.asInstanceOf[Expr[Seq[T]]]
   }
 
 

library/src/scala/quoted/Expr.scala

@@ -32,13 +32,13 @@ class QuoteContext(val tasty: scala.tasty.Reflection) { self =>
   /** Show the fully elaborated source code representation of an expression */
   def show(expr: Expr[_], syntaxHighlight: SyntaxHighlight): String = {
     import tasty.{_, given _}
-    expr.unseal.showWith(syntaxHighlight)
+    expr.unseal(using this).showWith(syntaxHighlight)
   }
 
   /** Show the fully elaborated source code representation of a type */
   def show(tpe: Type[_], syntaxHighlight: SyntaxHighlight): String = {
     import tasty.{_, given _}
-    tpe.unseal.showWith(syntaxHighlight)
+    tpe.unseal(using this).showWith(syntaxHighlight)
   }
 
   /** Report an error at the position of the macro expansion */
@@ -50,7 +50,7 @@ class QuoteContext(val tasty: scala.tasty.Reflection) { self =>
   /** Report an error at the on the position of `expr` */
   def error(msg: => String, expr: Expr[Any]): Unit = {
     import tasty.{_, given _}
-    tasty.error(msg, expr.unseal.pos)
+    tasty.error(msg, expr.unseal(using this).pos)
   }
 
   /** Report an error at the position of the macro expansion and throws a StopQuotedContext */
@@ -73,7 +73,7 @@ class QuoteContext(val tasty: scala.tasty.Reflection) { self =>
   /** Report a warning at the on the position of `expr` */
   def warning(msg: => String, expr: Expr[_]): Unit = {
     import tasty.{_, given _}
-    tasty.warning(msg, expr.unseal.pos)
+    tasty.warning(msg, expr.unseal(using this).pos)
   }
 
 }

library/src/scala/quoted/QuoteContext.scala

@@ -12,6 +12,10 @@ class Type[T <: AnyKind] private[scala] {
   /** Show a source code like representation of this type */
   def show(syntaxHighlight: SyntaxHighlight)(using qctx: QuoteContext): String = qctx.show(this, syntaxHighlight)
 
+  /** View this expression `quoted.Type[T]` as a `TypeTree` */
+  def unseal(using qctx: QuoteContext): qctx.tasty.TypeTree =
+    qctx.tasty.internal.QuotedType_unseal(this)(using qctx.tasty.rootContext)
+
 }
 
 /** Some basic type tags, currently incomplete */

library/src/scala/quoted/Type.scala

@@ -415,26 +415,6 @@ class Reflection(private[scala] val internal: CompilerInterface) { self =>
   type AmbiguousImplicits = internal.AmbiguousImplicits
 
 
-  ////////////////
-  //   QUOTES   //
-  ////////////////
-
-  extension QuotedExprOps on (expr: scala.quoted.Expr[?]) {
-    /** View this expression `quoted.Expr[T]` as a `Term` */
-    def unseal(using ctx: Context): Term =
-      internal.QuotedExpr_unseal(expr)
-
-    /** Checked cast to a `quoted.Expr[U]` */
-    def cast[U](using tp: scala.quoted.Type[U], ctx: Context): scala.quoted.Expr[U] =
-      internal.QuotedExpr_cast[U](expr)
-  }
-
-  extension QuotedTypeOps on [T <: AnyKind](tpe: scala.quoted.Type[T]) {
-    /** View this expression `quoted.Type[T]` as a `TypeTree` */
-    def unseal(using ctx: Context): TypeTree =
-      internal.QuotedType_unseal(tpe)
-  }
-
   //////////////
   // CONTEXTS //
   //////////////
@@ -1592,7 +1572,8 @@ class Reflection(private[scala] val internal: CompilerInterface) { self =>
   ///////////////
 
   /** Returns the type (Type) of T */
-  def typeOf[T](using qtype: scala.quoted.Type[T], ctx: Context): Type = qtype.unseal.tpe
+  def typeOf[T](using qtype: scala.quoted.Type[T], ctx: Context): Type =
+    internal.QuotedType_unseal(qtype).tpe
 
   /** Members of `TypeOrBounds` */
   extension TypeOrBoundsOps on (tpe: TypeOrBounds) {

library/src/scala/tasty/Reflection.scala

@@ -4,7 +4,7 @@ import scala.quoted.matching._
 inline def f: Any = ${ fImpl }
 
 private def fImpl(using qctx: QuoteContext): Expr[Unit] = {
-  import qctx.tasty.{_, given _}
+  import qctx.tasty._
   searchImplicit(('[A]).unseal.tpe) match {
     case x: ImplicitSearchSuccess =>
       '{}

tests/neg-macros/delegate-match-1/Macro_1.scala

@@ -4,7 +4,7 @@ import scala.quoted.matching._
 inline def f: Any = ${ fImpl }
 
 private def fImpl (using qctx: QuoteContext) : Expr[Unit] = {
-  import qctx.tasty.{_, given _}
+  import qctx.tasty._
   searchImplicit(('[A]).unseal.tpe) match {
     case x: ImplicitSearchSuccess =>
       '{}

tests/neg-macros/delegate-match-2/Macro_1.scala

@@ -4,7 +4,7 @@ import scala.quoted.matching._
 inline def f: Any = ${ fImpl }
 
 private def fImpl(using qctx: QuoteContext) : Expr[Unit] = {
-  import qctx.tasty.{_, given _}
+  import qctx.tasty._
   searchImplicit(('[A]).unseal.tpe) match {
     case x: ImplicitSearchSuccess =>
       '{}