-Wall of shame

Author: som-snytt

compiler/src/dotty/tools/dotc/config/ScalaSettings.scala

@@ -309,6 +309,7 @@ private sealed trait WarningSettings:
     def enumCommentDiscard(using Context): Boolean = allOr(WenumCommentDiscard)
     def implausiblePatterns(using Context): Boolean = allOr(WimplausiblePatterns)
     def unstableInlineAccessors(using Context): Boolean = allOr(WunstableInlineAccessors)
+    def toStringInterpolated(using Context): Boolean = allOr(WtoStringInterpolated)
     def checkInit(using Context): Boolean = allOr(WcheckInit)
 
 /** -X "Extended" or "Advanced" settings */

compiler/src/dotty/tools/dotc/transform/localopt/FormatChecker.scala

@@ -221,7 +221,7 @@ class TypedFormatChecker(partsElems: List[Tree], parts: List[String], args: List
         case _ => true
 
     def lintToString(arg: Type): Unit =
-      if ctx.settings.WtoStringInterpolated.value && kind == StringXn && !(arg.widen =:= defn.StringType) && !arg.isPrimitiveValueType
+      if ctx.settings.Whas.toStringInterpolated && kind == StringXn && !(arg.widen =:= defn.StringType) && !arg.isPrimitiveValueType
       then warningAt(CC)("interpolation uses toString")
 
     // what arg type if any does the conversion accept

compiler/src/dotty/tools/dotc/transform/localopt/StringInterpolatorOpt.scala

@@ -110,7 +110,7 @@ class StringInterpolatorOpt extends MiniPhase:
     end mkConcat
     def lintToString(t: Tree): Unit =
       val arg: Type = t.tpe
-      if ctx.settings.WtoStringInterpolated.value && !(arg.widen =:= defn.StringType) && !arg.isPrimitiveValueType
+      if ctx.settings.Whas.toStringInterpolated && !(arg.widen =:= defn.StringType) && !arg.isPrimitiveValueType
       then report.warning("interpolation uses toString", t.srcPos)
     val sym = tree.symbol
     // Test names first to avoid loading scala.StringContext if not used, and common names first