Merge pull request #14893 from dotty-staging/fix-11170

Handle case where abstract overrides miss an implementation

Author: bishabosha

compiler/src/dotty/tools/dotc/core/NameOps.scala

@@ -361,5 +361,14 @@ object NameOps {
       case raw.BANG  => UNARY_!
       case _ => name
     }
+
+    /** If this is a super accessor name, its underlying name, which is the name
+     *  of the method that the super accessor forwards to.
+     */
+    def originalOfSuperAccessorName: TermName = name match
+      case SuperAccessorName(name1)   => name1.originalOfSuperAccessorName
+      case ExpandedName(_, name1)     => name1.originalOfSuperAccessorName
+      case ExpandPrefixName(_, name1) => name1.originalOfSuperAccessorName
+      case _ => name
   }
 }

compiler/src/dotty/tools/dotc/transform/ResolveSuper.scala

@@ -118,7 +118,10 @@ object ResolveSuper {
           report.error(IllegalSuperAccessor(base, memberName, targetName, acc, accTp, other.symbol, otherTp), base.srcPos)
       bcs = bcs.tail
     }
-    assert(sym.exists, i"cannot rebind $acc, ${acc.targetName} $memberName")
-    sym
+    sym.orElse {
+      val originalName = acc.name.asTermName.originalOfSuperAccessorName
+      report.error(em"Member method ${originalName.debugString} of mixin ${acc.owner} is missing a concrete super implementation in $base.", base.srcPos)
+      acc
+    }
   }
 }

tests/neg/i11170.check

@@ -0,0 +1,4 @@
+-- Error: tests/neg/i11170.scala:7:15 ----------------------------------------------------------------------------------
+7 |abstract class A extends U[String] // error
+  |               ^
+  |               Member method foo of mixin trait U is missing a concrete super implementation in class A.

tests/neg/i11170.scala

@@ -0,0 +1,8 @@
+trait T[X] {
+  def foo(x: X): X
+}
+trait U[X] extends T[X] {
+  abstract override def foo(x: X): X = super.foo(x)
+}
+abstract class A extends U[String] // error
+

tests/neg/i11170a.scala

@@ -0,0 +1,28 @@
+package apackage {
+
+  abstract class A {
+    protected val x: Int
+  }
+  abstract class A2 {
+    val x: Int
+  }
+}
+
+package bpackage {
+  import apackage._
+
+  trait B extends A {
+    println(x)
+  }
+  trait B2 extends A2 {
+    println(x)
+  }
+}
+
+package cpackage {
+  import apackage._
+  import bpackage._
+
+  case class C(override protected val x: Int) extends A with B  // error
+  case class C2(override val x: Int) extends A2 with B2
+}

tests/pos/MathSpec.scala

@@ -0,0 +1,21 @@
+trait MathSig {
+  def sqrt(x: Double): Double
+}
+
+trait MathSpec extends MathSig {
+  val epsilon = 0.00001
+  abstract override def sqrt(x: Double) = {
+    require(x >= 0)
+    super.sqrt(x)
+  } ensuring { result =>
+    (x * x - result).abs < epsilon
+  }
+}
+
+trait MathImpl extends MathSig {
+  def sqrt(x: Double): Double =
+    ???
+}
+
+object Math extends MathImpl
+               with MathSpec