Fix vulpix to fail on error free neg tests

Author: OlivierBlanvillain

compiler/test/dotty/tools/dotc/CompilationTests.scala

@@ -189,7 +189,6 @@ class CompilationTests extends ParallelTesting {
     compileFile("../tests/neg-custom-args/xfatalWarnings.scala", defaultOptions.and("-Xfatal-warnings")) +
     compileFile("../tests/neg-custom-args/i3561.scala", defaultOptions.and("-Xfatal-warnings")) +
     compileFile("../tests/neg-custom-args/pureStatement.scala", defaultOptions.and("-Xfatal-warnings")) +
-    compileFile("../tests/neg-custom-args/i3589-a.scala", defaultOptions.and("-Xfatal-warnings")) +
     compileFile("../tests/neg-custom-args/i2333.scala", defaultOptions.and("-Xfatal-warnings")) +
     compileFile("../tests/neg-custom-args/i3882.scala", allowDeepSubtypes) +
     compileFile("../tests/neg-custom-args/phantom-overload.scala", allowDoubleBindings) +

compiler/test/dotty/tools/vulpix/ParallelTesting.scala

@@ -783,29 +783,22 @@ trait ParallelTesting extends RunnerOrchestration { self =>
           }
         }
 
-        if (compilerCrashed) {
-          echo(s"Compiler crashed when compiling: ${testSource.title}")
-          failTestSource(testSource)
-        }
-        else if (expectedErrors != actualErrors) {
-          echo {
-            s"\nWrong number of errors encountered when compiling $testSource, expected: $expectedErrors, actual: $actualErrors\n"
-          }
-          failTestSource(testSource)
-        }
-        else if (hasMissingAnnotations()) {
-          echo {
-            s"\nErrors found on incorrect row numbers when compiling $testSource"
-          }
-          failTestSource(testSource)
-        }
-        else if (!errorMap.isEmpty) {
-          echo {
-            s"\nExpected error(s) have {<error position>=<unreported error>}: $errorMap"
-          }
+        def fail(msg: String): Unit = {
+          echo(msg)
           failTestSource(testSource)
         }
 
+        if (compilerCrashed)
+          fail(s"Compiler crashed when compiling: ${testSource.title}")
+        else if (actualErrors == 0)
+          fail(s"\nNo errors found when compiling neg test $testSource")
+        else if (expectedErrors != actualErrors)
+          fail(s"\nWrong number of errors encountered when compiling $testSource, expected: $expectedErrors, actual: $actualErrors")
+        else if (hasMissingAnnotations())
+          fail(s"\nErrors found on incorrect row numbers when compiling $testSource")
+        else if (!errorMap.isEmpty)
+          fail(s"\nExpected error(s) have {<error position>=<unreported error>}: $errorMap")
+
         registerCompletion(actualErrors)
       }
     }