Homogenize pattern var method names

Author: nicolasstucki

compiler/src/dotty/tools/dotc/ast/TreeInfo.scala

@@ -160,7 +160,7 @@ trait TreeInfo[T >: Untyped <: Type] { self: Trees.Instance[T] =>
 
   /** Is tree a variable pattern? */
   def isVarPattern(pat: Tree): Boolean = unsplice(pat) match {
-    case x: Ident => x.name.isVariableName && !isBackquoted(x)
+    case x: Ident => x.name.isVarPattern && !isBackquoted(x)
     case _  => false
   }
 

compiler/src/dotty/tools/dotc/core/NameOps.scala

@@ -79,8 +79,8 @@ object NameOps {
       case name: SimpleName => name.exists(isOperatorPart)
       case _ => false
 
-    /** Is name a variable name? */
-    def isVariableName: Boolean =
+    /** Is name of a variable pattern? */
+    def isVarPattern: Boolean =
       testSimple { n =>
         n.length > 0 && {
           val first = n.head

compiler/src/dotty/tools/dotc/parsing/Parsers.scala

@@ -2594,7 +2594,7 @@ object Parsers {
         val givenMod = atSpan(in.skipToken())(Mod.Given())
         atSpan(in.offset) {
           in.token match {
-            case IDENTIFIER | USCORE if in.name.isVariableName =>
+            case IDENTIFIER | USCORE if in.name.isVarPattern =>
               val name = in.name
               in.nextToken()
               accept(COLON)

compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala

@@ -194,7 +194,7 @@ object PatternMatcher {
         case Typed(_, tpt) if tpt.tpe.isRepeatedParam => true
         case Bind(nme.WILDCARD, WildcardPattern()) => true // don't skip when binding an interesting symbol!
         case t if isWildcardArg(t)                 => true
-        case x: Ident                              => x.name.isVariableName && !isBackquoted(x)
+        case x: Ident                              => x.name.isVarPattern && !isBackquoted(x)
         case Alternative(ps)                       => ps.forall(unapply)
         case EmptyTree                             => true
         case _                                     => false