Address review comments

Author: Duhemm

compiler/src/dotty/tools/dotc/core/tasty/CommentPickler.scala

@@ -8,7 +8,7 @@ import dotty.tools.dotc.core.tasty.TastyBuffer.Addr
 import java.nio.charset.Charset
 
 class CommentPickler(pickler: TastyPickler, addrOfTree: tpd.Tree => Option[Addr])(implicit ctx: Context) {
-  val buf = new TastyBuffer(5000)
+  private[this] val buf = new TastyBuffer(5000)
   pickler.newSection("Comments", buf)
 
   def pickleComment(root: tpd.Tree): Unit =
@@ -21,7 +21,7 @@ class CommentPickler(pickler: TastyPickler, addrOfTree: tpd.Tree => Option[Addr]
       buf.writeAddr(addr)
       buf.writeNat(length)
       buf.writeBytes(bytes, length)
-      buf.writeBoolean(cmt.isExpanded)
+      buf.writeByte(if (cmt.isExpanded) 1 else 0)
     case other =>
       ()
   }

compiler/src/dotty/tools/dotc/core/tasty/CommentUnpickler.scala

@@ -19,7 +19,7 @@ class CommentUnpickler(reader: TastyReader) {
       val length = readNat()
       if (length > 0) {
         val bytes = readBytes(length)
-        val expanded = readBoolean()
+        val expanded = readByte() == 1
         val rawComment = new String(bytes, Charset.forName("UTF-8"))
         comments(addr) = Comment(Positions.NoPosition, rawComment, expanded = expanded)
       }

compiler/src/dotty/tools/dotc/core/tasty/TastyBuffer.scala

@@ -48,10 +48,6 @@ class TastyBuffer(initialSize: Int) {
 
   // -- Output routines --------------------------------------------
 
-  /** Write a boolean value. */
-  def writeBoolean(b: Boolean): Unit =
-    writeByte(if (b) 1 else 0)
-
   /** Write a byte of data. */
   def writeByte(b: Int): Unit = {
     if (length >= bytes.length)

compiler/src/dotty/tools/dotc/core/tasty/TastyFormat.scala

@@ -224,7 +224,9 @@ Standard Section: "Positions" Assoc*
 
 Standard Section: "Comments" Comment*
 
-  Comment       = Length Bytes              // Raw comment's bytes encoded as UTF-8
+  Comment       = Length Bytes Byte         // Raw comment's bytes encoded as UTF-8, plus a byte indicating
+                                            // whether the comment is expanded (1) or not expanded (0)
+
 
 **************************************************************************************/
 

compiler/src/dotty/tools/dotc/core/tasty/TastyReader.scala

@@ -41,10 +41,6 @@ class TastyReader(val bytes: Array[Byte], start: Int, end: Int, val base: Int =
   def subReader(start: Addr, end: Addr): TastyReader =
     new TastyReader(bytes, index(start), index(end), base)
 
-  /** Read a boolean value. */
-  def readBoolean(): Boolean =
-    readByte() == 1
-
   /** Read a byte of data. */
   def readByte(): Int = {
     val result = bytes(bp) & 0xff