SimplePattern errors should now be recovered as wildcard instead of unimplemented expr (#21438)

rochala · web-flow · commit f036195971c6 · 2024-08-26T16:32:59.000+02:00
We should not emit more errors that came from our error recovery term trees. Previously, we've recovered those situations with unimplemented expression term added in #19103 and before that it was just a `null`
diff --git a/compiler/src/dotty/tools/dotc/parsing/Parsers.scala b/compiler/src/dotty/tools/dotc/parsing/Parsers.scala
@@ -3198,7 +3198,7 @@ object Parsers {
         else {
           val start = in.lastOffset
           syntaxErrorOrIncomplete(IllegalStartOfSimplePattern(), expectedOffset)
-          errorTermTree(start)
+          atSpan(Span(start, in.offset)) { Ident(nme.WILDCARD) }
         }
     }
 
diff --git a/tests/neg/i5004.scala b/tests/neg/i5004.scala
@@ -2,5 +2,5 @@ object i0 {
 1 match {
 def this(): Int  // error
   def this()
-} // error
+}
 }
diff --git a/tests/neg/parser-stability-1.scala b/tests/neg/parser-stability-1.scala
@@ -1,4 +1,3 @@
 object x0 {
 x1 match  // error
 def this // error
-// error

Original file line number	Diff line number	Diff line change
`@@ -3198,7 +3198,7 @@ object Parsers {`
`3198`	`3198`	`else {`
`3199`	`3199`	`val start = in.lastOffset`
`3200`	`3200`	`syntaxErrorOrIncomplete(IllegalStartOfSimplePattern(), expectedOffset)`
`3201`		`- errorTermTree(start)`
	`3201`	`+ atSpan(Span(start, in.offset)) { Ident(nme.WILDCARD) }`
`3202`	`3202`	`}`
`3203`	`3203`	`}`
`3204`	`3204`
Original file line number	Diff line number	Diff line change
`@@ -2,5 +2,5 @@ object i0 {`
`2`	`2`	`1 match {`
`3`	`3`	`def this(): Int // error`
`4`	`4`	`def this()`
`5`		`-} // error`
	`5`	`+}`
`6`	`6`	`}`