chore: check name when renaming

Author: kasiaMarek

presentation-compiler/src/main/dotty/tools/pc/PcRenameProvider.scala

@@ -18,11 +18,19 @@ final class PcRenameProvider(
     name: Option[String]
 ) extends WithSymbolSearchCollector[l.TextEdit](driver, params):
   private val forbiddenMethods =
-    Set("equals", "hashCode", "unapply", "unary_!", "!")
+    Set("equals", "hashCode", "unapply", "apply", "<init>", "unary_!", "!")
+
+  private val soughtSymbolNames = soughtSymbols match
+    case Some((symbols, _)) =>
+      symbols.filterNot(_.isError).map(symbol => symbol.decodedName.toString)
+    case None => Set.empty[String]
+
   def canRenameSymbol(sym: Symbol)(using Context): Boolean =
-    (!sym.is(Method) || !forbiddenMethods(sym.decodedName))
-      && (sym.ownersIterator.drop(1).exists(ow => ow.is(Method))
-        || sym.source.path.isWorksheet)
+    val decodedName = sym.decodedName
+    def isForbiddenMethod = sym.is(Method) && forbiddenMethods(decodedName)
+    def local = sym.ownersIterator.drop(1).exists(ow => ow.is(Method))
+    def isInWorksheet = sym.source.path.isWorksheet
+    !isForbiddenMethod && (local || isInWorksheet) && soughtSymbolNames(decodedName)
 
   def prepareRename(): Option[l.Range] =
     soughtSymbols.flatMap((symbols, pos) =>

presentation-compiler/test/dotty/tools/pc/tests/edit/PcRenameSuite.scala

@@ -508,3 +508,29 @@ class PcRenameSuite extends BasePcRenameSuite:
         |    ???
         |  end bar""".stripMargin
     )
+
+  @Test def `apply-rename` =
+    check(
+     """|object B {
+        |  def locally = {
+        |    object A{ def app@@ly(a: Int) = ??? }
+        |    A(123)
+        |    A.apply(123)
+        |  }
+        |}
+        |""".stripMargin,
+     wrap = false
+   )
+
+  @Test def `constructor-rename` =
+   check(
+     """|object B {
+        |  def locally = {
+        |    class A(a : String){ def th@@is(a: Int) = this(a.toString) }
+        |    A(123)
+        |    A.apply(123)
+        |  }
+        |}
+        |""".stripMargin,
+     wrap = false
+   )