Check that methods are in fact parameterless

Author: nicolasstucki

compiler/src/dotty/tools/dotc/ast/tpd.scala

@@ -1039,8 +1039,10 @@ object tpd extends Trees.Instance[Type] with TypedTreeInfo {
     protected def skipLocal(sym: Symbol): Boolean = true
 
     /** Is this a symbol that of a local val or parameterless def for which we could get the rhs */
-    private def isBinding(sym: Symbol)(implicit ctx: Context): Boolean =
-      sym.exists && !sym.is(Param) && !sym.owner.isClass && !sym.isAnonymousFunction
+    private def isBinding(sym: Symbol)(implicit ctx: Context): Boolean = {
+      sym.exists && !sym.is(Param) && !sym.owner.isClass &&
+      !(sym.is(Method) && sym.info.isInstanceOf[MethodOrPoly]) // if is a method it is parameterless
+    }
   }
 
   implicit class ListOfTreeDecorator(val xs: List[tpd.Tree]) extends AnyVal {

tests/run/tasty-argument-tree-1.check

@@ -17,6 +17,15 @@ tree deref. vals: Term.Ident("a")
 tree: Term.Inlined(None, Nil, Term.Ident("x"))
 tree deref. vals: Term.Ident("b")
 
+tree: Term.Inlined(None, Nil, Term.Ident("x"))
+tree deref. vals: Term.Apply(Term.Ident("d2"), Nil)
+
+tree: Term.Inlined(None, Nil, Term.Ident("x"))
+tree deref. vals: Term.Apply(Term.Ident("d3"), List(Term.Literal(Constant.Int(3))))
+
+tree: Term.Inlined(None, Nil, Term.Ident("x"))
+tree deref. vals: Term.TypeApply(Term.Ident("d4"), List(TypeTree.Ident("Int")))
+
 tree: Term.Inlined(None, Nil, Term.Ident("vv"))
 tree deref. vals: Term.Literal(Constant.Int(1))
 

tests/run/tasty-argument-tree-1/quoted_2.scala

@@ -9,12 +9,18 @@ object Test {
     val v: Int = 1
     def d: Int = 2
     lazy val l: Int = 3
+    def d2(): Int = 2
+    def d3(a: Int): Int = a
+    def d4[T]: Int = 2
     inspect(3)
     inspect(v)
     inspect(d)
     inspect(l)
     inspect(a)
     inspect(b)
+    inspect(d2())
+    inspect(d3(3))
+    inspect(d4[Int])
 
     val vv = v
     def dv = v