update Analyzer

Author: liufengyun

sbt-dotty/sbt-test/sbt-dotty/analyzer-plugin/plugin/Analyzer.scala

@@ -12,7 +12,8 @@ import transform.MegaPhase.MiniPhase
 import Decorators._
 import Symbols.Symbol
 import Constants.Constant
-import transform.{Pickler, Staging}
+import Types._
+import transform.{SetDefTree, SetDefTreeOff}
 
 class InitChecker extends PluginPhase with StandardPlugin {
   import tpd._
@@ -22,35 +23,45 @@ class InitChecker extends PluginPhase with StandardPlugin {
 
   val phaseName = name
 
-  override val runsAfter = Set(Staging.name)
-  override val runsBefore = Set(Pickler.name)
+  override val runsAfter = Set(SetDefTree.name)
+  override val runsBefore = Set(SetDefTreeOff.name)
 
   def init(options: List[String]): List[PluginPhase] = this :: Nil
 
   private def checkDef(tree: Tree)(implicit ctx: Context): Tree = {
-    val span = tree.symbol.defTree.span
-    if (!(span.exists && span.end > span.start))
-      ctx.error("cannot get tree for " + tree.symbol.show, tree.sourcePos)
+    if (tree.symbol.defTree.isEmpty)
+      ctx.error("cannot get tree for " + tree.show, tree.sourcePos)
     tree
   }
 
-  private def checkRef(tree: Tree)(implicit ctx: Context): Tree = {
-    val helloPkgSym = ctx.requiredPackage("hello")
-    val libPkgSym = ctx.requiredPackage("lib")
-    val enclosingPkg = tree.symbol.enclosingPackageClass
-
-    if (enclosingPkg == helloPkgSym) {  // source code
-      checkDef(tree)
-    }
-    else if (enclosingPkg == libPkgSym) { // tasty from library
-      checkDef(tree)
-      // check that all sub-definitions have trees set properly
-      transformAllDeep(tree.symbol.defTree)
+  private def checkable(sym: Symbol)(implicit ctx: Context): Boolean =
+    sym.exists && !sym.isOneOf(Flags.Package) && !sym.isOneOf(Flags.Param) &&
+      (sym.isClass || !sym.isOneOf(Flags.Case, butNot = Flags.Enum)) // pattern-bound symbols
+
+  private def checkRef(tree: Tree)(implicit ctx: Context): Tree =
+    if (!checkable(tree.symbol)) tree
+    else {
+      val helloPkgSym = ctx.requiredPackage("hello").moduleClass
+      val libPkgSym = ctx.requiredPackage("lib").moduleClass
+      val enclosingPkg = tree.symbol.enclosingPackageClass
+
+      if (enclosingPkg == helloPkgSym) {  // source code
+        checkDef(tree)
+        ctx.warning("tree: " + tree.symbol.defTree.show)
+      }
+      else if (enclosingPkg == libPkgSym) { // tasty from library
+        checkDef(tree)
+        // check that all sub-definitions have trees set properly
+        // make sure that are no cycles in the code
+        transformAllDeep(tree.symbol.defTree)
+        ctx.warning("tree: " + tree.symbol.defTree.show)
+      }
+      else {
+        ctx.warning(tree.symbol + " is neither in lib nor hello, owner = " + enclosingPkg, tree.sourcePos)
+      }
+      tree
     }
 
-    tree
-  }
-
   override def transformValDef(tree: ValDef)(implicit ctx: Context): Tree = checkDef(tree)
 
   override def transformDefDef(tree: DefDef)(implicit ctx: Context): Tree = checkDef(tree)
@@ -60,4 +71,12 @@ class InitChecker extends PluginPhase with StandardPlugin {
   override def transformSelect(tree: Select)(implicit ctx: Context): Tree = checkRef(tree)
 
   override def transformIdent(tree: Ident)(implicit ctx: Context): Tree = checkRef(tree)
+
+  override def transformTypeTree(tree: TypeTree)(implicit ctx: Context): Tree = {
+    tree.tpe.foreachPart {
+      case tp: NamedType => checkRef(TypeTree(tp))
+      case _ =>
+    }
+    tree
+  }
 }