Add TODOs

Author: nicolasstucki

compiler/src/dotty/tools/backend/jvm/BCodeBodyBuilder.scala

@@ -331,7 +331,7 @@ trait BCodeBodyBuilder extends BCodeSkelBuilder {
           }
           val (fun, args) = call match {
             case Apply(fun, args) => (fun, args)
-            case t @ DesugaredSelect(_, _) => (t, Nil)
+            case t @ DesugaredSelect(_, _) => (t, Nil) // TODO: use Select
             case t @ Ident(_) => (t, Nil)
           }
 
@@ -517,7 +517,7 @@ trait BCodeBodyBuilder extends BCodeSkelBuilder {
           val sym       = const.symbolValue
           val ownerName = internalName(sym.owner)
           val fieldName = sym.javaSimpleName
-          val underlying = sym.info match {
+          val underlying = sym.info match { // TODO: Is this actually necessary? Could it be replaced by a call to widen?
             case t: TypeProxy => t.underlying
             case t => t
           }

compiler/src/dotty/tools/backend/jvm/BCodeSkelBuilder.scala

@@ -174,7 +174,7 @@ trait BCodeSkelBuilder extends BCodeHelpers {
         case _ => ()
       }
 
-      val ssa = None // getAnnotPickle(thisName, claszSymbol)
+      val ssa = None // TODO: inlined form `getAnnotPickle(thisName, claszSymbol)`. Should something be done on Dotty?
       cnode.visitAttribute(if (ssa.isDefined) pickleMarkerLocal else pickleMarkerForeign)
       emitAnnotations(cnode, claszSymbol.annotations ++ ssa)
 

compiler/src/dotty/tools/backend/jvm/BCodeSyncAndTry.scala

@@ -410,7 +410,7 @@ trait BCodeSyncAndTry extends BCodeBodyBuilder {
     }
 
     /* Does this tree have a try-catch block? */
-    def mayCleanStack(tree: Tree): Boolean = tree.find { t => t match {
+    def mayCleanStack(tree: Tree): Boolean = tree.find { t => t match { // TODO: use existsSubTree
         case Try(_, _, _) => true
         case _ => false
       }