Merge pull request #11242 from dotty-staging/fix-11236

Improve variable instantiation when member is missing

Author: odersky

compiler/src/dotty/tools/dotc/typer/Inferencing.scala

@@ -99,8 +99,23 @@ object Inferencing {
        && tvar.hasLowerBound =>
       tvar.instantiate(fromBelow = true)
       true
-    case AppliedType(tycon, _) =>
+    case AppliedType(tycon, args) =>
+      // The argument in `args` that may potentially appear directly as result
+      // and thereby influence the members of this type
+      def argsInResult: List[Type] = tycon match
+        case tycon: TypeRef =>
+          tycon.info match
+            case MatchAlias(_) => args
+            case TypeBounds(_, upper: TypeLambda) =>
+              upper.resultType match
+                case ref: TypeParamRef if ref.binder == upper =>
+                  args.lazyZip(upper.paramRefs).collect {
+                    case (arg, pref) if pref eq ref => arg
+                  }.toList
+                case _ => Nil
+            case _ => Nil
       couldInstantiateTypeVar(tycon)
+      || argsInResult.exists(couldInstantiateTypeVar)
     case RefinedType(parent, _, _) =>
       couldInstantiateTypeVar(parent)
     case tp: AndOrType =>

compiler/test/dotc/pos-test-pickling.blacklist

@@ -32,6 +32,7 @@ i7868.scala
 i7872.scala
 6709.scala
 6687.scala
+i11236.scala
 
 # Opaque type
 i5720.scala

tests/pos/i11236.scala

@@ -0,0 +1,22 @@
+class Test {
+  val tup: Char #: Int #: String #: TupleK = ???
+  val x: String #: TupleK = (tup.tail: Int #: String #: TupleK).tail
+  val a = tup.tail
+  val b = a.tail
+  val y: String #: TupleK = tup.tail.tail
+  val z: Unit = tup.tail.tail
+}
+
+trait TupleK
+
+object TupleK {
+  type Tail[X <: NonEmptyTupleK] <: TupleK = X match {
+    case _ #: xs => xs
+  }
+}
+
+trait NonEmptyTupleK extends TupleK {
+  /*inline*/ def tail[This >: this.type <: NonEmptyTupleK]: TupleK.Tail[This] = ???
+}
+
+abstract class #:[+H, +T <: TupleK] extends NonEmptyTupleK

tests/pos/i9567.scala

@@ -2,8 +2,11 @@
 //   val x: Int => Int = identity
 // }
 
-trait Foo[F[_]] {
+trait Foo[F[_], I[X] <: X] {
+  type Id[X] <: X
   def foo[G[x] >: F[x]]: G[Unit]
+  def foo2[X >: F[String]]: Id[X]
+  def foo3[X >: F[String]]: I[X]
 }
 
 trait M[A] {
@@ -12,11 +15,10 @@ trait M[A] {
 }
 
 object Test {
-  def bar(x: Foo[M]): Unit = {
-    // error: value bla is not a member of G[Unit], where:    G is a type variable with constraint >: M and <: [x] =>> Any
+  def bar(x: Foo[M, [X] =>> X]): Unit = {
     x.foo.bla
-
-    // error: value bla is not a member of G[Unit], where:    G is a type variable with constraint >: M and <: [x] =>> Any
     x.foo.baz(x => x)
+    x.foo2.bla
+    x.foo3.bla
   }
 }