revert changes and NoPosition fix

Author: rochala

compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala

@@ -2514,10 +2514,7 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler
         def fullName: String = self.denot.fullName.toString
 
         def pos: Option[Position] =
-          if self.exists && !self.lexicallyEnclosingClass.isOneOf(dotc.core.Flags.JavaDefined | dotc.core.Flags.Permanent) then
-            Some(self.sourcePos)
-          else
-            None
+          if self.exists then Some(self.sourcePos) else None
 
         def docstring: Option[String] =
           import dotc.core.Comments.CommentsContext

scaladoc/src/dotty/tools/scaladoc/api.scala

@@ -44,7 +44,7 @@ enum Modifier(val name: String, val prefix: Boolean):
   case Transparent extends Modifier("transparent", true)
   case Infix extends Modifier("infix", true)
 
-case class ExtensionTarget(name: String, typeParams: Seq[TypeParameter], argsLists: Seq[ParametersList], dri: DRI, position: Long)
+case class ExtensionTarget(name: String, typeParams: Seq[TypeParameter], argsLists: Seq[ParametersList], signature: Signature, dri: DRI, position: Long)
 case class ImplicitConversion(from: DRI, to: DRI)
 trait ImplicitConversionProvider { def conversion: Option[ImplicitConversion] }
 trait Classlike:

scaladoc/src/dotty/tools/scaladoc/renderers/Resources.scala

@@ -167,12 +167,13 @@ trait Resources(using ctx: DocContext) extends Locations, Writer:
     def extensionTarget(member: Member): String =
       member.kind match
         case Kind.Extension(on, _) =>
-          val typeSig = InlineSignatureBuilder()
+          val typeSig = SignatureBuilder()
+            .keyword("extension ")
             .generics(on.typeParams)
-            .asInstanceOf[InlineSignatureBuilder].names.reverse
-          val argsSig = InlineSignatureBuilder()
+            .content
+          val argsSig = SignatureBuilder()
             .functionParameters(on.argsLists)
-            .asInstanceOf[InlineSignatureBuilder].names.reverse
+            .content
           flattenToText(typeSig ++ argsSig)
         case _ => ""
 

scaladoc/src/dotty/tools/scaladoc/tasty/ClassLikeSupport.scala

@@ -151,6 +151,7 @@ trait ClassLikeSupport:
             extSym.symbol.normalizedName,
             typeParams,
             termParams,
+            extSym.tpt.asSignature,
             extSym.tpt.symbol.dri,
             extSym.symbol.pos.get.start
           )

scaladoc/src/dotty/tools/scaladoc/tasty/SymOps.scala

@@ -154,11 +154,16 @@ object SymOps:
     def splitExtensionParamList: (List[reflect.ParamClause], List[reflect.ParamClause]) =
       import reflect.*
 
+      def getPositionStartOption(pos: Option[Position]): Option[Int] = pos.flatMap {
+        case dotty.tools.dotc.util.NoSourcePosition => None
+        case pos: Position => Some(pos.start)
+      }
+
       def comparePositionStarts(posA: Option[Position], posB: Option[Position]): Option[Boolean] =
         for {
-          a <- posA
-          b <- posB
-        } yield a.start < b.start
+          startA <- getPositionStartOption(posA)
+          startB <- getPositionStartOption(posB)
+        } yield startA < startB
 
       sym.tree match
         case tree: DefDef =>

scaladoc/src/dotty/tools/scaladoc/transformers/ImplicitMembersExtensionTransformer.scala

@@ -26,7 +26,7 @@ class ImplicitMembersExtensionTransformer(using DocContext) extends(Module => Mo
 
       val MyDri = c.dri
       def collectApplicableMembers(source: Member): Seq[Member] = source.members.flatMap {
-        case m @ Member(_, _, _, Kind.Extension(ExtensionTarget(_, _, _, MyDri, _), _), Origin.RegularlyDefined) =>
+        case m @ Member(_, _, _, Kind.Extension(ExtensionTarget(_, _, _, _, MyDri, _), _), Origin.RegularlyDefined) =>
           val kind = m.kind match
             case Kind.Extension(_, d) => d
             case _ => Kind.Def(Nil, Nil)