Check if symbol was moved to a companion when bringing forward denotation

While bringing forward the denotation to a new run, check if the
symbol was moved from its owner to a companion object. If so, return
NoDenotation, as that denotation seems to be a leftover from
pre-MoveStatics phases in a previous run.

Author: jchyb

compiler/src/dotty/tools/dotc/core/Denotations.scala

@@ -2,7 +2,7 @@ package dotty.tools
 package dotc
 package core
 
-import SymDenotations.{ SymDenotation, ClassDenotation, NoDenotation, LazyType, stillValid, acceptStale, traceInvalid }
+import SymDenotations.{ SymDenotation, ClassDenotation, NoDenotation, LazyType, stillValid, movedToCompanionClass, acceptStale, traceInvalid }
 import Contexts.*
 import Names.*
 import NameKinds.*
@@ -755,6 +755,11 @@ object Denotations {
       }
       if (!symbol.exists) return updateValidity()
       if (!coveredInterval.containsPhaseId(ctx.phaseId)) return NoDenotation
+      // Moved to a companion class, likely at a later phase (in MoveStatics)
+      this match {
+        case symd: SymDenotation if movedToCompanionClass(symd) => return NoDenotation
+        case _ =>
+      }
       if (ctx.debug) traceInvalid(this)
       staleSymbolError
     }

compiler/src/dotty/tools/dotc/core/SymDenotations.scala

@@ -2680,6 +2680,10 @@ object SymDenotations {
         stillValidInOwner(denot)
     }
 
+  def movedToCompanionClass(denot: SymDenotation)(using Context): Boolean =
+    val ownerCompanion = denot.maybeOwner.companionClass
+    stillValid(ownerCompanion) && ownerCompanion.unforcedDecls.contains(denot.name, denot.symbol)
+
   private[SymDenotations] def stillValidInOwner(denot: SymDenotation)(using Context): Boolean = try
     val owner = denot.maybeOwner.denot
     stillValid(owner)

tests/pos-macros/i21271/Macro.scala

@@ -0,0 +1,12 @@
+import scala.quoted.*
+
+trait Schema
+object Schema:
+  lazy val sampleDate: String = "" // lazy val requried to reproduce
+
+  inline def derived: Schema =
+    annotations
+    new Schema {}
+
+inline def annotations: Int = ${ annotationsImpl }
+def annotationsImpl(using Quotes): Expr[Int] = Expr(1)

tests/pos-macros/i21271/Test.scala

@@ -0,0 +1 @@
+val inputValueSchema = Schema.derived