Disallow package names as types

Fixes #12432

Author: odersky

compiler/src/dotty/tools/dotc/transform/PostTyper.scala

@@ -263,6 +263,10 @@ class PostTyper extends MacroTransform with IdentityDenotTransformer { thisPhase
         case Select(qual, _) => check(qual)    // simple select _n
         case Apply(TypeApply(Select(qual, _), _), _) => check(qual) // generic select .apply[T](n)
 
+    def checkNotPackage(tree: Tree)(using Context): Unit =
+      if tree.symbol.is(Package) then
+        report.error(i"${tree.symbol} cannot be used as a type", tree.srcPos)
+
     override def transform(tree: Tree)(using Context): Tree =
       try tree match {
         // TODO move CaseDef case lower: keep most probable trees first for performance
@@ -273,21 +277,25 @@ class PostTyper extends MacroTransform with IdentityDenotTransformer { thisPhase
              case None =>
                ctx
           super.transform(tree)(using gadtCtx)
-        case tree: Ident if !tree.isType =>
-          if tree.symbol.is(Inline) && !Inliner.inInlineMethod then
-            ctx.compilationUnit.needsInlining = true
-          checkNoConstructorProxy(tree)
-          tree.tpe match {
-            case tpe: ThisType => This(tpe.cls).withSpan(tree.span)
-            case _ => tree
-          }
+        case tree: Ident =>
+          if tree.isType then
+            checkNotPackage(tree)
+            tree
+          else
+            if tree.symbol.is(Inline) && !Inliner.inInlineMethod then
+              ctx.compilationUnit.needsInlining = true
+            checkNoConstructorProxy(tree)
+            tree.tpe match {
+              case tpe: ThisType => This(tpe.cls).withSpan(tree.span)
+              case _ => tree
+            }
         case tree @ Select(qual, name) =>
           if tree.symbol.is(Inline) then
             ctx.compilationUnit.needsInlining = true
-          if (name.isTypeName) {
+          if name.isTypeName then
+            checkNotPackage(tree)
             Checking.checkRealizable(qual.tpe, qual.srcPos)
             withMode(Mode.Type)(super.transform(tree))
-          }
           else
             checkNoConstructorProxy(tree)
             transformSelect(tree, Nil)

tests/neg/i12432.scala

@@ -0,0 +1,4 @@
+package dotty.tools.dotc.typer
+
+class i1 ( i1 : annotation ) // error
+class i2 ( a : scala.annotation ) // error